Date: Mon, 8 Sep 2003 20:21:47 -0700
From: Andrew Morton <akpm@osdl.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: mingo@redhat.com, drepper@redhat.com, roland@redhat.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use group_leader->pgrp (was Re: setpgid and threads)
Message-Id: <20030908202147.3cba2ecd.akpm@osdl.org>
In-Reply-To: <1063073637.4004.14.camel@localhost.localdomain>
References: <1061424262.24785.29.camel@localhost.localdomain>
	<20030820194940.6b949d9d.akpm@osdl.org>
	<1063072786.4004.11.camel@localhost.localdomain>
	<20030908191215.22f501a2.akpm@osdl.org>
	<1063073637.4004.14.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1120
Lines: 39

Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
> On Mon, 2003-09-08 at 19:12, Andrew Morton wrote:
> > and to then rename task_struct.pgrp to something else, to pick up any
> > missed conversions?
> 
> Probably a good idea.

Caught a few:

drivers/char/tty_io.c: In function `tty_check_change':
drivers/char/tty_io.c:332: structure has no member named `pgrp'
drivers/char/tty_io.c:334: structure has no member named `pgrp'

	if (is_orphaned_pgrp(current->pgrp))
		return -EIO;
	(void) kill_pg(current->pgrp,SIGTTOU,1);

should these be converted?


drivers/char/tty_io.c: In function `tty_open':
drivers/char/tty_io.c:1409: structure has no member named `pgrp'

		tty->pgrp = current->pgrp;

this one?

drivers/char/tty_io.c: In function `tiocsctty':
drivers/char/tty_io.c:1583: structure has no member named `pgrp'

        tty->pgrp = current->pgrp;

and this.  I think so?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/