Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V6 07/38] x86/intel_rdt: Initialize new resource group
 with sane defaults
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     fenghua.yu@intel.com, tony.luck@intel.com,
        vikas.shivappa@linux.intel.com, gavin.hindman@intel.com,
        jithu.joseph@intel.com, dave.hansen@intel.com, mingo@redhat.com,
        hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org
References: <68030110df15615d95731fd354ff7adfb0476d37.1527593970.git.reinette.chatre@intel.com>
 <44af4ecef879e88ec1b74c5decbf5dccaf998866.1528405422.git.reinette.chatre@intel.com>
 <alpine.DEB.2.21.1806191418460.1684@nanos.tec.linutronix.de>
 <fa7e3fa0-cf3b-df77-4b45-988ec3420843@intel.com>
 <alpine.DEB.2.21.1806191851520.10546@nanos.tec.linutronix.de>
From:   Reinette Chatre <reinette.chatre@intel.com>
Message-ID: <c97ad611-a040-f3a9-0aae-632a6f1f4dc6@intel.com>
Date:   Tue, 19 Jun 2018 10:06:39 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.1806191851520.10546@nanos.tec.linutronix.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Thomas,

On 6/19/2018 9:53 AM, Thomas Gleixner wrote:
> On Tue, 19 Jun 2018, Reinette Chatre wrote:
>> On 6/19/2018 5:31 AM, Thomas Gleixner wrote:
>>> On Thu, 7 Jun 2018, Reinette Chatre wrote:
>>>> +static void cbm_ensure_valid(u32 *_val, struct rdt_resource *r)
>>>> +{
>>>> +	unsigned long *val = (unsigned long *)_val;
>>>
>>> I'm a bit worried about the u32 to unsigned long case here. I know that
>>> cbm_len cannot exceed 32, but still. At least it wants a comment.
>>
>> Will do.
>>
>> I am planning to add the following to the next version.
> 
> Don't bother. I'm picking up the delta as I'm halfways through the whole
> thing by now and if there is no major update pending from your side, I'm
> going to merge it as is.

Thank you very much. I do not have anything else pending from my side at
this time.

Reinette