Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC v7 0/1] mconf: global i-search in menu prompts
To:     Dirk Gouders <dirk@gouders.net>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Segher Boessenkool <segher@kernel.crashing.org>,
        Sam Ravnborg <sam@ravnborg.org>
References: <20180617121534.4809-1-dirk@gouders.net>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <87d68443-ad2c-50e0-ef10-f6a9f349c050@infradead.org>
Date:   Tue, 19 Jun 2018 10:27:03 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180617121534.4809-1-dirk@gouders.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 06/17/2018 05:15 AM, Dirk Gouders wrote:
> Hello,
> 
> Most noticeable changes are that the exact starting position before
> doing i-search is now remebered and i-search stays on the current item
> if a character was added and the new string also matches this item.

Nice.

> Also, compiler warnings were eliminated and A_UNDERLINE was replaced
> with A_STANDOUT to mark active menu items when the focus is on the
> buttons, because I tested mconf on a tty where underlines were not
> visible.  For a complete list of changes see below.

This highlight/standout is good, helpful.

> Dirk
> 
> Changes in v7:
> 
> 
> * Rework i-search instructions text

For the (old) menu_instructions[] string:  that has a hard time fitting in
80x25 or 80x30 console.  I.e., it is being truncated.  I had to resize the
console to 90x30 to see all of it.  Oh well.

> * Remember exact starting position in menu
> 
> * Stay on menu item if it matches pattern with a character added
> 
> * Fix print_autowrap for short texts
> 
> * Focus on buttons: use A_STANDOUT for current menu item

:)

[snip]


I like it.

thanks,
-- 
~Randy