Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180615174204.30581-1-pasha.tatashin@oracle.com>
 <20180615174204.30581-2-pasha.tatashin@oracle.com> <alpine.DEB.2.21.1806191928040.10546@nanos.tec.linutronix.de>
In-Reply-To: <alpine.DEB.2.21.1806191928040.10546@nanos.tec.linutronix.de>
From:   Pavel Tatashin <pasha.tatashin@oracle.com>
Date:   Tue, 19 Jun 2018 13:50:54 -0400
Message-ID: <CAGM2reYc7bgcqjqhvattvRMQefxpNXU3FkXJdC1XrGQVpRzsxQ@mail.gmail.com>
Subject: Re: [PATCH v10 1/7] x86/tsc: remove tsc_disabled flag
To:     tglx@linutronix.de
Cc:     Steven Sistare <steven.sistare@oracle.com>,
        Daniel Jordan <daniel.m.jordan@oracle.com>,
        linux@armlinux.org.uk, schwidefsky@de.ibm.com,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        john.stultz@linaro.org, sboyd@codeaurora.org, x86@kernel.org,
        LKML <linux-kernel@vger.kernel.org>, mingo@redhat.com,
        hpa@zytor.com, douly.fnst@cn.fujitsu.com, peterz@infradead.org,
        prarit@redhat.com, feng.tang@intel.com,
        Petr Mladek <pmladek@suse.com>, gnomes@lxorguk.ukuu.org.uk
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > tsc_disabled is set when notsc is passed as kernel parameter. The reason we
> > have notsc is to avoid timing problems on multi-socket systems.  We already
> > have a mechanism, however, to detect and resolve these issues by invoking
> > tsc unstable path. Thus, make notsc to behave the same as tsc=unstable.
>
> notsc also excludes TSC from being used at all, while with your change its
> suddenly used in sched_clock().

Hi Thomas,

Thank you for the review. I will reword the patch comment. Currently,
at the end it says: "Thus, make notsc to behave the same as
tsc=unstable." To emphasize this, I will change the patch title to
this:

x86/tsc: redefine notsc to behave as tsc=unstable

And in the comment I will mention that as a consequence of this change
tsc is going to be used by sched_clock() when notsc is provided.

Thank you,
Pavel