Subject: Re: [PATCH] use group_leader->pgrp (was Re: setpgid and threads)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Ulrich Drepper <drepper@redhat.com>, mingo@redhat.com,
       Roland McGrath <roland@redhat.com>,
       Linux Kernel List <linux-kernel@vger.kernel.org>
In-Reply-To: <20030908211746.25fff0f1.akpm@osdl.org>
References: <1061424262.24785.29.camel@localhost.localdomain>
	 <20030820194940.6b949d9d.akpm@osdl.org>
	 <1063072786.4004.11.camel@localhost.localdomain>
	 <20030908191215.22f501a2.akpm@osdl.org>
	 <1063073637.4004.14.camel@localhost.localdomain>
	 <20030908202147.3cba2ecd.akpm@osdl.org> <3F5D4EFA.30102@redhat.com>
	 <20030908211746.25fff0f1.akpm@osdl.org>
Content-Type: text/plain
Message-Id: <1063086977.12268.17.camel@ixodes.goop.org>
Mime-Version: 1.0
Date: Mon, 08 Sep 2003 22:56:17 -0700
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 767
Lines: 19

On Mon, 2003-09-08 at 21:17, Andrew Morton wrote:
> All other instances of foo->pgrp have been converted to process_group(foo),
> which is foo->group_leader->__pgrp.
> 
> Should setpgrp() in a thread affect the group leader?   It does...

Eh?  sys_setpgid() fails with EINVAL if another thread tries to change
the process group.  Oh, I see.  setpgrp() is a wrapper which passes
pid=0 to setpgid; sys_setpgid uses current->pid rather than
current->tgid, so it always uses the thread group leader's ID.  Looks OK
to me.

	J

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/