Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp72390imm; Tue, 19 Jun 2018 14:31:30 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKikDZZS8KWcnmt2MeNFoAmvemrVGQqSIWIc2AIiZeBVYp6kZTSu0rQJxqBEWqqiGjuKIqs X-Received: by 2002:a17:902:3f81:: with SMTP id a1-v6mr20685878pld.29.1529443890692; Tue, 19 Jun 2018 14:31:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529443890; cv=none; d=google.com; s=arc-20160816; b=LhjLORv6QvRxh7T613rSA590Y2uYPJL/yeCQunpt9kwRzRWHIB5JXeVgKarvbN4xJU jjn2GaQ89id/I9xMD2mHD5gPr4tvKrlx4fKUwz9K+4fKpUV9PZM9MrufwmQ2sfXOZYzw ytTvu0ECh26cHeTiBsRSAL2PpMwULBrboK7quSimbAZfCGVHL0/pwz9XvTkymqTDx3Ha Z+Qr3WC5YZ4HUEegKcIyru7BoEgUet/Lbibn/J405lKM//80flB40A3CXAsDdQ/efyei QcWJlforFpAE33us68Am/vJDFN8XElhkBxUVxunNzejyFcw83ZGFzHVT8bdfCLrelVSJ d+cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=gfE0XtuHFtmEG5q7s851qZq3b7M+To9b6I5aODlN2Hc=; b=g9duc2qfsesWq2LLSQK1lFTQLn09omS7Upu2WCfig/RoN3+me2k/1zTYSS6ow6sbAq nsclzFwGd9WYYrjx7w9jpXchLwrx0lIwDpjVsCdLF0MoqRG6TPzMfxI8UemUlNMySCSi e1aN6Y0I+tQXki91DXxRbSuAJBzeRWrdhyUhRzP8NLo1CKrxgYj2g/+755sCuSramHas PNpAbN1NCqEe0fvfUU4PxqnXZnPwtu+31jYyHujROZn7Vv1yI0lb1dKVsQ+raOnLcDYH mgANvimoE7GU2OY74eIHjPfWbyoDova3oytL31nHF4CT+DbTkx34/btKZTp9PtJVbf1Z hSKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v131-v6si530834pgb.466.2018.06.19.14.30.52; Tue, 19 Jun 2018 14:31:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757452AbeFSV2Z (ORCPT + 99 others); Tue, 19 Jun 2018 17:28:25 -0400 Received: from mail.bugwerft.de ([46.23.86.59]:50674 "EHLO mail.bugwerft.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966934AbeFSV15 (ORCPT ); Tue, 19 Jun 2018 17:27:57 -0400 Received: from localhost.localdomain (pD95EF733.dip0.t-ipconnect.de [217.94.247.51]) by mail.bugwerft.de (Postfix) with ESMTPSA id 2BFF628A295; Tue, 19 Jun 2018 21:24:51 +0000 (UTC) From: Daniel Mack To: zbr@ioremap.net, robh+dt@kernel.org, mark.rutland@arm.com, szabolcs.gyurko@tlt.hu Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Mack Subject: [PATCH RFC 4/4] w1: ds2760: add devicetree matching glue Date: Tue, 19 Jun 2018 23:27:44 +0200 Message-Id: <20180619212744.794-5-daniel@zonque.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180619212744.794-1-daniel@zonque.org> References: <20180619212744.794-1-daniel@zonque.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add an id table for ds2760 so it can be matched by the core. Also, refrain from allocating the platform device for the supply driver at runtime when the device was matched via DT, because in this case, supply devices are also probed with device tree nodes, so they will always be present. Signed-off-by: Daniel Mack --- drivers/w1/slaves/w1_ds2760.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2760.c b/drivers/w1/slaves/w1_ds2760.c index 26168abfb8b8..a737a96204ed 100644 --- a/drivers/w1/slaves/w1_ds2760.c +++ b/drivers/w1/slaves/w1_ds2760.c @@ -17,6 +17,7 @@ #include #include #include +#include #include @@ -131,6 +132,9 @@ static int w1_ds2760_add_slave(struct w1_slave *sl) int ret; struct platform_device *pdev; + if (sl->dev.of_node) + return 0; + pdev = platform_device_alloc("ds2760-battery", PLATFORM_DEVID_AUTO); if (!pdev) return -ENOMEM; @@ -154,9 +158,17 @@ static void w1_ds2760_remove_slave(struct w1_slave *sl) { struct platform_device *pdev = dev_get_drvdata(&sl->dev); - platform_device_unregister(pdev); + if (!sl->dev.of_node) + platform_device_unregister(pdev); } +#ifdef CONFIG_OF +static const struct of_device_id w1_ds2760_of_ids[] = { + { .compatible = "maxim,w1-ds2760" }, + {} +}; +#endif + static struct w1_family_ops w1_ds2760_fops = { .add_slave = w1_ds2760_add_slave, .remove_slave = w1_ds2760_remove_slave, @@ -166,6 +178,7 @@ static struct w1_family_ops w1_ds2760_fops = { static struct w1_family w1_ds2760_family = { .fid = W1_FAMILY_DS2760, .fops = &w1_ds2760_fops, + .of_match_table = of_match_ptr(w1_ds2760_of_ids), }; module_w1_family(w1_ds2760_family); -- 2.17.1