Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp29885imm; Tue, 19 Jun 2018 15:16:18 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKddr7aBLBUhUjnzfLJnex0nJ3F6Ooae3e7oKgfJMeq+lPBSZosdsLaLxZuO6/kCvrbxnu4 X-Received: by 2002:a62:a0c:: with SMTP id s12-v6mr20127434pfi.33.1529446578920; Tue, 19 Jun 2018 15:16:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529446578; cv=none; d=google.com; s=arc-20160816; b=ok5OPSI8xxdVl7y/BRNtEH/VgZlQgU+W8sm1ehTFEtQ1PNEOufTQIsNNhG20A3tpMU ob1ft+V0J4KzaOT5viX85XC2zfuNCc3CP2mZ9qn4WTyM9JUxunJxPWIw6cPA00nA8jEH 6SxXKIYI8y8pIK9lMQIJTQ02o8EqLLhDrhLlVDxBWGNEwftHwLkP1ue5dLBJHlOj/aYH J6yAy5coM7zRggN3cxUJP9ZUB18vAStQrmSnpGtC4QnNMyyTMHQFm/NIAntLvZ67PFBr bg+QCEpoWVlnbc8TgUs9FCGgWI3IDqV3+juHjLogNpNHytw3AD3FBxn8qoDSZQ7UUTZ8 J+zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=RWt3tXcQpeUKl5rhF4qU27Ajs1Gduhg5+iWsEwWGMuQ=; b=HF55c3572IhHAh7C7VHvNttVBBdmF6qfutMj2njDcdgWCqGA/52YJsDB4QxJhtszq/ 8l8jAI1uvcrRZqsjKnN1/9sNV7rxAUKyw8FFLRO0B7Bkq5M5Oj+TIoZ39Z3wtohlVRuo ToqdqLbFR1IXwmiIQSCzBBbcTmQq8mfANTjG5HOGEgvypy52CWqaAn6gApVdDnV4YDxt Qfp953Mg1Sj72bkRStZFqk+TyOQ21fOBQ8r3Mpntg0W/mXTTzk1mJ2IqabjOiASXWJYO hnG+rHm05L/GISN98i6XwtHKXzIgA5ODA1mbtH5sLgb3+L1tVHNBoBPsQ60DFuoU53+9 CZHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=PedjQRDn; dkim=pass header.i=@codeaurora.org header.s=default header.b=hDLC+qaH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v137-v6si575384pgb.682.2018.06.19.15.16.05; Tue, 19 Jun 2018 15:16:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=PedjQRDn; dkim=pass header.i=@codeaurora.org header.s=default header.b=hDLC+qaH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964933AbeFSWPF (ORCPT + 99 others); Tue, 19 Jun 2018 18:15:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50024 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755448AbeFSWO7 (ORCPT ); Tue, 19 Jun 2018 18:14:59 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E529560AD8; Tue, 19 Jun 2018 22:14:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1529446499; bh=1Vjl39tLmeWbAQlnCL3SxfLl17ip8C8gZdW1QC7AxPM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=PedjQRDn7xr3zn09I2bMsfe/oYlv5us2TYtAaAqxUvRV2ynCZLUNxTYew7ML80YTy VpkXtarMU6Pg8I2h3Zt0svUKyUwQ51QvavRwDY9dw4j2DL6PtfNiaulVD/VHwviBAG NKXAv74QQK6sBVzVKMvI+hV4s3zG3OZ+9tbLPogI= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.0.106] (cpe-174-109-247-98.nc.res.rr.com [174.109.247.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id CF30B60AD9; Tue, 19 Jun 2018 22:14:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1529446498; bh=1Vjl39tLmeWbAQlnCL3SxfLl17ip8C8gZdW1QC7AxPM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=hDLC+qaHE8xhlzPO8zI70KSt0avo1vn1tuTd4dy4OQf1YnJtrY1UGfdzcukztOZQQ t7Mm7dN45sGgPnMwT45ADcQX7nt0yr3/CTDLC6VpEejd4XHOvrcOxK0ht0Pg1TDFmO LBUM0WPGsOZm4k2l64mNKOtH2w0jw2ZFtFeEhrmo= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CF30B60AD9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH] efi/fb: Convert PCI bus address to resource if translated by the bridge To: Bjorn Helgaas Cc: Robin Murphy , linux-pci@vger.kernel.org, timur@codeaurora.org, ard.biesheuvel@linaro.org, "open list:EFIFB FRAMEBUFFER DRIVER" , Bartlomiej Zolnierkiewicz , linux-arm-msm@vger.kernel.org, open list , "open list:FRAMEBUFFER LAYER" , Peter Jones , linux-arm-kernel@lists.infradead.org References: <1526563343-28721-1-git-send-email-okaya@codeaurora.org> <36cf3f12-bfe8-1c38-4d2c-b785fc64a3f6@arm.com> <733101d0-9051-a5a6-ef64-162d8d1e10a1@codeaurora.org> <20180619215955.GF33049@bhelgaas-glaptop.roam.corp.google.com> From: Sinan Kaya Message-ID: <61384244-49f9-2020-04f0-6e188cf6a6b7@codeaurora.org> Date: Tue, 19 Jun 2018 18:14:55 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180619215955.GF33049@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, On 6/19/2018 5:59 PM, Bjorn Helgaas wrote: > On Fri, May 18, 2018 at 10:20:29AM -0400, Sinan Kaya wrote: >> On 5/18/2018 6:42 AM, Robin Murphy wrote: >>> >>> FWIW, now that I've actually gone and looked, it appears you could simplify the whole function quite a bit by getting rid of these and just using the new local resource directly, especially since the only actual use of size is an open-coded resource_contains(). >> >> Posted V2 a minute ago. I did the simplification on a prior patch in order not to >> mix the issues. > > I don't see the V2 on linux-pci, but it sounds like Ard would merge this > anyway. So I'll drop this and you can let me know if there's anything you > need from me. > It is planned to go through fbdev tree for 4.19. https://patchwork.kernel.org/patch/10410895/ Feel free to review/ACK. Sinan -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.