Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 19 Jun 2018 18:29:30 -0500
From:   "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>
To:     Souptick Joarder <jrdr.linux@gmail.com>
Cc:     Uma Krishnan <ukrishn@linux.vnet.ibm.com>,
        Matthew Wilcox <willy@infradead.org>,
        "Manoj N. Kumar" <manoj@linux.vnet.ibm.com>,
        James Bottomley <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        linux-kernel@vger.kernel.org,
        Sabyasachi Gupta <sabyasachi.linux@gmail.com>,
        brajeswar.linux@gmail.com
Subject: Re: [PATCH] scsi: cxlflash: Change return type for fault handler
References: <20180611194204.GA18687@jordon-HP-15-Notebook-PC>
 <20180613232347.GA3851@p8tul1-build.aus.stglabs.ibm.com>
 <CAFqt6zb-fDRdH1_k7QwW_YEErKYPYFNpJFrK7N82P0PLiKnRtA@mail.gmail.com>
 <1E0C8AFA-5168-4916-932E-8E1C3F0EADE6@linux.vnet.ibm.com>
 <CAFqt6zbgaqVxAVcX+ryzP5-qDDZs+Z1rNrY4mHhwr=THO++5Vg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFqt6zbgaqVxAVcX+ryzP5-qDDZs+Z1rNrY4mHhwr=THO++5Vg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Message-Id: <20180619232930.GB10658@p8tul1-build.aus.stglabs.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 19, 2018 at 11:11:35PM +0530, Souptick Joarder wrote:
> On Tue, Jun 19, 2018 at 7:41 PM, Uma Krishnan
> <ukrishn@linux.vnet.ibm.com> wrote:
> >
> >
> >> On Jun 19, 2018, at 12:10 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> >>
> >> On Thu, Jun 14, 2018 at 4:53 AM, Matthew R. Ochs
> >> <mrochs@linux.vnet.ibm.com> wrote:
> >>> On Tue, Jun 12, 2018 at 01:12:04AM +0530, Souptick Joarder wrote:
> >>>> Use new return type vm_fault_t for fault handler. For
> >>>> now, this is just documenting that the function returns
> >>>> a VM_FAULT value rather than an errno. Once all instances
> >>>> are converted, vm_fault_t will become a distinct type.
> >>>>
> >>>> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
> >>>>
> >>>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> >>>
> >>> This looks fine to me.
> >>>
> >>> FYI that there is another handler for this driver in a series
> >>> destined for 4.18 and currently in next/master.
> >>>
> >>> Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
> >>>
> >>
> >> Matthew, is this patch queued for 4.19 ?
> >>
> > Below is the commit that added fault handler in ocxl. It is in 4.18 rc1 (upstream/master tree)
> >
> > commit 93b8f8df552c5a30bfddb75a632f1b2a436c2cae
> >     scsi: cxlflash: Support adapter context mmap and release
> 
> 
> No, that's a different patch with commit
> 93b8f8df552c5a30bfddb75a632f1b2a436c2cae.
> Not the patch under discussion in this mail thread :)
> 
> Anyway the other patch with commit 93b8f8df552c5a30b also has to be modified
> to use new return type vm_fault_t for fault handler ocxlflash_mmap_fault().
> 
> Shall I modify and submit the same ?
> 

Since this has not yet been queued for 4.19, please submit a v2 with the
modifications to also update the return type for ocxlflash_mmap_fault().


-matt