Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp123917imm; Tue, 19 Jun 2018 17:25:08 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJCAN0+EUd7JClAn3d1sxtn/oGScM/vZ8y2nb8Vf6qA5CSMQ0nXDtHWHw/gI2cTHHiq+Q77 X-Received: by 2002:a17:902:5390:: with SMTP id c16-v6mr21164280pli.104.1529454308388; Tue, 19 Jun 2018 17:25:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529454308; cv=none; d=google.com; s=arc-20160816; b=0LtwRYx8Zrp64diYhvuWJg5lst4+AsdbP6mhRXLXiatkmn/4sa8QIkPJmYmcL21JM5 kLafvTLMWOvBxPmzyLZ+ewSo4JfZcEyiD5a+DsWOLDT2TnA2xrUuW0XXs4ugXwMXxPrx PJawEcluyhJmHFeDWVWd/hoh0KskPA+Z3JqxO4woMWZtdJVMIwQukwYqDH0pSuAkHOs/ QgXVb5eddYb8I95eN/sYjcjzDyN87assqh5BrbzokThgXmAGWe2HY2VYkT3aWwv6XCJr +ad4/6g+ruV57dFJt/2c86zcIgXv0REPb92GVKdYYu/zT+8+PZgJEs65CzhWWrxx8CsN ZLbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=mZuS3/jVLvS2SVLY+QqZ+GnCnvGg0DeyT7XbV9baKcA=; b=pzlGz6RbwcEkfuBBMShMQTYzjVnVwQ8f64UAhwOi55QyyL9lvcmTRQt/rAryhbSlIM IcnkdUX27kG1qHOgVbhL7/PJFRtmrb98slt1GK+xdlRGhqJqg9YzjsfJ+xXmVNO1gpxH ZhjrYqhuu99CHRpI1hviVfTsseLXv+tIO5GsIR3AkfwCIf6Q/k5ZCnF6JPcYfDsXCPU8 MhSY4CxqPt0Pt3rr5WuEdOuvgQCKY+lYMvpdlNYDwazq4u+lybNAwfDOTXzFk6IoiHxZ /I/RJtnWehvTHOoYYm2QnfE9yKV3/lsxcNLFxOodca9tI1JO//+ub7At67lXjM/AvNOZ Wjpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n7-v6si989683pfn.270.2018.06.19.17.24.54; Tue, 19 Jun 2018 17:25:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754046AbeFTAWo (ORCPT + 99 others); Tue, 19 Jun 2018 20:22:44 -0400 Received: from 9pmail.ess.barracuda.com ([64.235.154.211]:54041 "EHLO 9pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753141AbeFTAWl (ORCPT ); Tue, 19 Jun 2018 20:22:41 -0400 Received: from mipsdag03.mipstec.com (mail3.mips.com [12.201.5.33]) by mx1401.ess.rzc.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=NO); Wed, 20 Jun 2018 00:22:29 +0000 Received: from mipsdag02.mipstec.com (10.20.40.47) by mipsdag03.mipstec.com (10.20.40.48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1415.2; Tue, 19 Jun 2018 17:22:28 -0700 Received: from localhost (10.20.2.29) by mipsdag02.mipstec.com (10.20.40.47) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Tue, 19 Jun 2018 17:22:28 -0700 Date: Tue, 19 Jun 2018 17:22:29 -0700 From: Paul Burton To: Masahiro Yamada CC: Ralf Baechle , James Hogan , "linux-mips@linux-mips.org" , Kees Cook , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 4/7] MIPS: boot: correct prerequisite image of vmlinux.*.its Message-ID: <20180620002229.xsh4bupxa72nhjoh@pburton-laptop> References: <1523890067-13641-1-git-send-email-yamada.masahiro@socionext.com> <1523890067-13641-5-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1523890067-13641-5-git-send-email-yamada.masahiro@socionext.com> User-Agent: NeoMutt/20180512 X-BESS-ID: 1529454149-321457-29061-17275-1 X-BESS-VER: 2018.7-r1806151722 X-BESS-Apparent-Source-IP: 12.201.5.33 X-BESS-Envelope-From: Paul.Burton@mips.com X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.194209 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-Orig-Rcpt: yamada.masahiro@socionext.com,ralf@linux-mips.org,jhogan@kernel.org,linux-mips@linux-mips.org,keescook@chromium.org,linux-kernel@vger.kernel.org X-BESS-BRTS-Status: 1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, Thanks for these - I've applied patches 1-3, 5 & 6 to mips-next for 4.19. On Mon, Apr 16, 2018 at 07:47:44AM -0700, Masahiro Yamada wrote: > vmlinux.*.its does not directly depend on $(VMLINUX) but > vmlinux.bin.* This isn't really true - to generate the .its we actually do depend on the ELF, which we read the entry address from (entry-y in arch/mips/Makefile, provided to arch/mips/boot/Makefile as VMLINUX_ENTRY_ADDRESS). In practice $(VMLINUX) is built before this makefile is ever invoked anyway, but the dependency is there. We don't need the vmlinux.bin.* file until we generate the .itb, so it should be fine for the .its & .bin steps to be executed in parallel which this patch would prevent. Thanks, Paul