Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264029AbTIILkO (ORCPT ); Tue, 9 Sep 2003 07:40:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264031AbTIILkO (ORCPT ); Tue, 9 Sep 2003 07:40:14 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:23479 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S264029AbTIILkK (ORCPT ); Tue, 9 Sep 2003 07:40:10 -0400 Date: Tue, 9 Sep 2003 13:40:14 +0200 From: Jens Axboe To: Andries Brouwer Cc: Matthew Wilcox , Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [PATCH] use size_t for the broken ioctl numbers Message-ID: <20030909114014.GG4755@suse.de> References: <20030907062248.GX18654@parcelfarce.linux.theplanet.co.uk> <20030908123846.GA15553@win.tue.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030908123846.GA15553@win.tue.nl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 23 On Mon, Sep 08 2003, Andries Brouwer wrote: > On Sun, Sep 07, 2003 at 07:22:48AM +0100, Matthew Wilcox wrote: > > > Clearly it's too late to change the ioctl definitions, but we can at > > least stop people from copying them and making the same mistake. > > > -#define BLKELVSET _IOW(0x12,107,sizeof(blkelv_ioctl_arg_t))/* elevator set */ > > +#define BLKELVSET _IOW(0x12,107,size_t)/* elevator set */ > > Here we lose information - I don't like that. > Often it is important to know what kind of argument an ioctl has, > and that info should be easy to find. Just kill them, they are not used. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/