Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp516835imm; Wed, 20 Jun 2018 02:04:55 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJFAzdkyocU3wmLVv4p8705VbWdfq/kD8sRQ+DcM3LhznvFMrigX+6fsaCmZ2d+vAJQIB22 X-Received: by 2002:a17:902:8e87:: with SMTP id bg7-v6mr22659695plb.129.1529485495244; Wed, 20 Jun 2018 02:04:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529485495; cv=none; d=google.com; s=arc-20160816; b=QTFwIm1nhqFZrmbvCQ3oC0tyOfN6OA+F3MEibuwOAjZc7Q8jZKRKh3b9m3h4NE/8H+ zi+5fPeTJ4CxHs1LyeIv7Q214XU32zwTSqq92Z3gjQ5kiKOCuuLRWaNRfGkO+EFP0ZKN icE5h0gCRl3Ln3rIQBP5MAWojsMG/30AUFIZ/5gf0XzAnPDEPWUnwQ/+383A5JilQU+j fI3Y3Xg/Z9WeiNK6lLOH+wkhxrhwAG+neZztx/MO9Zc9I9K3/j8T27pjDT4OvGuDKyur UfC57QA6bhKhr6TXbgW2dwSLS7KXDaAqBgbe+jzRL9OHzfIzuVXQvWW7cSUkENWfMMf/ JBEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :arc-authentication-results; bh=gMMG/TQqBkfzuv/ofST/CrGy7mEWcOmFY3AvgBRXesc=; b=bvu6jvIfBO2WL8fNCD8Y5tegzqN+AifNYndVR32nnraGSK4yt+kgrZxenJROxdll5z sHczVkwWoTjJOXiNBan1W3UADv2rojjWRID1+9RvG4LUYmseL05YI2trnYM76IWyo+o5 k0s8tPh5rRrtxF1ooix3MvjZu4eROK/zl7Pj5/z0iePTDnq+Vvl4KNGySMtbuVOj5VyM felNgsPmrPhGkhbe32XeJWqOU2AEfm2ORWOA5hsaJZ0+fgTGVtCaqex7p/ch/pYh5w5P VyuU4jQszZlesqyaVtp06zY+qwszo/+rnwELsY9Nad51d4Ytb4k4egf7q4N7egQQASVl cVpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m8-v6si1616852pgq.637.2018.06.20.02.04.41; Wed, 20 Jun 2018 02:04:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754801AbeFTJDq (ORCPT + 99 others); Wed, 20 Jun 2018 05:03:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:60460 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752601AbeFTJDn (ORCPT ); Wed, 20 Jun 2018 05:03:43 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0A647AD85; Wed, 20 Jun 2018 06:52:18 +0000 (UTC) Subject: Re: [PATCH] xen: Fix two possible sleep-in-atomic-context bugs in create_active() To: Jia-Ju Bai , boris.ostrovsky@oracle.com Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20180620023846.30618-1-baijiaju1990@gmail.com> From: Juergen Gross Openpgp: preference=signencrypt Autocrypt: addr=jgross@suse.com; prefer-encrypt=mutual; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNHkp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmRlPsLAeQQTAQIAIwUCU4xw6wIbAwcL CQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJELDendYovxMvi4UH/Ri+OXlObzqMANruTd4N zmVBAZgx1VW6jLc8JZjQuJPSsd/a+bNr3BZeLV6lu4Pf1Yl2Log129EX1KWYiFFvPbIiq5M5 kOXTO8Eas4CaScCvAZ9jCMQCgK3pFqYgirwTgfwnPtxFxO/F3ZcS8jovza5khkSKL9JGq8Nk czDTruQ/oy0WUHdUr9uwEfiD9yPFOGqp4S6cISuzBMvaAiC5YGdUGXuPZKXLpnGSjkZswUzY d9BVSitRL5ldsQCg6GhDoEAeIhUC4SQnT9SOWkoDOSFRXZ+7+WIBGLiWMd+yKDdRG5RyP/8f 3tgGiB6cyuYfPDRGsELGjUaTUq3H2xZgIPfOwE0EU4xwFgEIAMsx+gDjgzAY4H1hPVXgoLK8 B93sTQFN9oC6tsb46VpxyLPfJ3T1A6Z6MVkLoCejKTJ3K9MUsBZhxIJ0hIyvzwI6aYJsnOew cCiCN7FeKJ/oA1RSUemPGUcIJwQuZlTOiY0OcQ5PFkV5YxMUX1F/aTYXROXgTmSaw0aC1Jpo w7Ss1mg4SIP/tR88/d1+HwkJDVW1RSxC1PWzGizwRv8eauImGdpNnseneO2BNWRXTJumAWDD pYxpGSsGHXuZXTPZqOOZpsHtInFyi5KRHSFyk2Xigzvh3b9WqhbgHHHE4PUVw0I5sIQt8hJq 5nH5dPqz4ITtCL9zjiJsExHuHKN3NZsAEQEAAcLAXwQYAQIACQUCU4xwFgIbDAAKCRCw3p3W KL8TL0P4B/9YWver5uD/y/m0KScK2f3Z3mXJhME23vGBbMNlfwbr+meDMrJZ950CuWWnQ+d+ Ahe0w1X7e3wuLVODzjcReQ/v7b4JD3wwHxe+88tgB9byc0NXzlPJWBaWV01yB2/uefVKryAf AHYEd0gCRhx7eESgNBe3+YqWAQawunMlycsqKa09dBDL1PFRosF708ic9346GLHRc6Vj5SRA UTHnQqLetIOXZm3a2eQ1gpQK9MmruO86Vo93p39bS1mqnLLspVrL4rhoyhsOyh0Hd28QCzpJ wKeHTd0MAWAirmewHXWPco8p1Wg+V+5xfZzuQY0f4tQxvOpXpt4gQ1817GQ5/Ed/wsDtBBgB CAAgFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAlrd8NACGwIAgQkQsN6d1ii/Ey92IAQZFggA HRYhBFMtsHpB9jjzHji4HoBcYbtP2GO+BQJa3fDQAAoJEIBcYbtP2GO+TYsA/30H/0V6cr/W V+J/FCayg6uNtm3MJLo4rE+o4sdpjjsGAQCooqffpgA+luTT13YZNV62hAnCLKXH9n3+ZAgJ RtAyDWk1B/0SMDVs1wxufMkKC3Q/1D3BYIvBlrTVKdBYXPxngcRoqV2J77lscEvkLNUGsu/z W2pf7+P3mWWlrPMJdlbax00vevyBeqtqNKjHstHatgMZ2W0CFC4hJ3YEetuRBURYPiGzuJXU pAd7a7BdsqWC4o+GTm5tnGrCyD+4gfDSpkOT53S/GNO07YkPkm/8J4OBoFfgSaCnQ1izwgJQ jIpcG2fPCI2/hxf2oqXPYbKr1v4Z1wthmoyUgGN0LPTIm+B5vdY82wI5qe9uN6UOGyTH2B3p hRQUWqCwu2sqkI3LLbTdrnyDZaixT2T0f4tyF5Lfs+Ha8xVMhIyzNb1byDI5FKCb Message-ID: Date: Wed, 20 Jun 2018 08:52:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180620023846.30618-1-baijiaju1990@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/06/18 04:38, Jia-Ju Bai wrote: > The driver may sleep with holding a spinlock. > The function call paths (from bottom to top) in Linux-4.16.7 are: > > [FUNC] __get_free_pages(GFP_KERNEL) > drivers/xen/pvcalls-front.c, 351: __get_free_pages in create_active > drivers/xen/pvcalls-front.c, 800: create_active in pvcalls_front_accept > drivers/xen/pvcalls-front.c, 783: spin_lock in pvcalls_front_accept > > [FUNC] __get_free_pages(GFP_KERNEL) > drivers/xen/pvcalls-front.c, 347: __get_free_pages in create_active > drivers/xen/pvcalls-front.c, 800: create_active in pvcalls_front_accept > drivers/xen/pvcalls-front.c, 783: spin_lock in pvcalls_front_accept > > To fix these bugs, GFP_KERNEL is replaced with GFP_ATOMIC. > > These bugs are found by my static analysis tool (DSAC-2) and checked by my > code review. > > Signed-off-by: Jia-Ju Bai Reviewed-by: Juergen Gross Juergen