Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp575296imm; Wed, 20 Jun 2018 03:12:44 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKzksgX3hzj00p/fVMc9Fl2P4GA2ryTaSbrpZU2GvBHpWOePw3aUDV1mfhO7uxqXlzzMKSB X-Received: by 2002:a63:ba4b:: with SMTP id l11-v6mr17586764pgu.295.1529489564258; Wed, 20 Jun 2018 03:12:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529489564; cv=none; d=google.com; s=arc-20160816; b=pLDZC/rLMsBiBAaZAdqLQeJZpL9bQzT36148m0+/zzLnzRehnIPCT9R2mWJu2Ln6UF /2ve9xyWfMtVbozjNhwl1Afr3HV56OckLonaPRXi9grGO6JDLEV1gp9SyJA/zEDe8G+n FuJ+26sztf7Rp1WsOvVJ8JlWRojEtKF35ykmqWSjpvktYyWIC2wJQ3cWHOXVXcxt7tOV NiN02ehQzHFmxOHxRkgHvagm8NOpXJED5WHQjtIq7TuDXwWXQNI09eJup0y3lfWKg/hH Q+9eb9vYeLaXr7987GQebzX+i6y0rwm6OElSuzj1wzp1QlltR7jSBGobElH2TPQP/wch I/5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=z8R0jbBMxPDSfNWqMdLeGaCfGeLPHySLAViwTat5vk0=; b=bWUSp6ofzc6nuRvv8s/yaP0TVntNQlwh8GBfIk0GpEv0/yqf9sWq4wo+vSJBPdFbMT nOu/CMZy29bou5DZ2oSW15Xy2BrsWwf1P8eZmr4+WFJVldbOVmnNA95CigdRHH6OJVL1 tLc8UVQ9Df7qC9nAwNOBMi9WlIDJPKHEVAK44vBOElS3mr83WqqiE4EHOFJLknW4xqzK s1lCMoXcejK1HryIWmggWyrM2G+qZcsaWD8Q9RBqiMV04PUEgHkxISCjNavKAj/8yYXW w26vGxOqtrkNTFxE/WVAVzGzLAwjwT8qI+PGvLs6XMrJcL5SFDb5r9H56IxPlf2iStoY uuzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=gPGIedkm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e12-v6si1666970pgn.171.2018.06.20.03.12.29; Wed, 20 Jun 2018 03:12:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=gPGIedkm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932132AbeFTKLi (ORCPT + 99 others); Wed, 20 Jun 2018 06:11:38 -0400 Received: from merlin.infradead.org ([205.233.59.134]:52272 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754251AbeFTKLe (ORCPT ); Wed, 20 Jun 2018 06:11:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=z8R0jbBMxPDSfNWqMdLeGaCfGeLPHySLAViwTat5vk0=; b=gPGIedkmrrgwlS3l1MlwDqhef uZlpq06GVY22xlLn1E+oeEWut+PtE7QveN1lG+4o25KF7PToXX0j6khCvyC5uQMukI6W3xc2sd/Wi qPwjJTrq8D934XBop6GcvzSpdp5aiWM386T4Fxu+C9hQ6/iMVqz2jHXyOgYvUt5qtmB0V1m+s1oTT 39sCjIZbSoSm+1kJk2g/lsYz43uUKBkmGMlyoacl7jnfjuJYqRErwkZb/XfD1a7bAyVPOi8fo2i9g 3hssU7VUC1NYce8CNlNJuJAB4Qrav3lOHMrJhL1zghGe7Jb3oXczlQFtUP9S12RDbu7VcJCBtVihV ar8VIAprQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fVa4u-0002TD-EE; Wed, 20 Jun 2018 10:11:05 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id CE2882029FA0A; Wed, 20 Jun 2018 12:11:01 +0200 (CEST) Date: Wed, 20 Jun 2018 12:11:01 +0200 From: Peter Zijlstra To: Nadav Amit Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Masahiro Yamada , Sam Ravnborg , Alok Kataria , Christopher Li , Greg Kroah-Hartman , "H. Peter Anvin" , Ingo Molnar , Jan Beulich , Josh Poimboeuf , Juergen Gross , Kate Stewart , Kees Cook , linux-sparse@vger.kernel.org, Philippe Ombredanne , Thomas Gleixner , virtualization@lists.linux-foundation.org, Linus Torvalds Subject: Re: [PATCH v5 0/9] x86: macrofying inline asm for better compilation Message-ID: <20180620101101.GB2530@hirez.programming.kicks-ass.net> References: <20180619194854.69486-1-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180619194854.69486-1-namit@vmware.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 19, 2018 at 12:48:45PM -0700, Nadav Amit wrote: > Nadav Amit (9): > Makefile: Prepare for using macros for inline asm > x86: objtool: use asm macro for better compiler decisions > x86: refcount: prevent gcc distortions > x86: alternatives: macrofy locks for better inlining > x86: bug: prevent gcc distortions > x86: prevent inline distortion by paravirt ops > x86: extable: use macros instead of inline assembly > x86: cpufeature: use macros instead of inline assembly > x86: jump-labels: use macros instead of inline assembly > > Makefile | 9 ++- > arch/x86/Makefile | 11 ++- > arch/x86/include/asm/alternative-asm.h | 20 ++++-- > arch/x86/include/asm/alternative.h | 11 +-- > arch/x86/include/asm/asm.h | 61 +++++++--------- > arch/x86/include/asm/bug.h | 98 +++++++++++++++----------- > arch/x86/include/asm/cpufeature.h | 82 ++++++++++++--------- > arch/x86/include/asm/jump_label.h | 65 ++++++++++------- > arch/x86/include/asm/paravirt_types.h | 56 +++++++-------- > arch/x86/include/asm/refcount.h | 74 +++++++++++-------- > arch/x86/kernel/macros.S | 16 +++++ > include/asm-generic/bug.h | 8 +-- > include/linux/compiler.h | 56 +++++++++++---- > scripts/Kbuild.include | 4 +- > scripts/mod/Makefile | 2 + > 15 files changed, 340 insertions(+), 233 deletions(-) > create mode 100644 arch/x86/kernel/macros.S Aside from the one niggle: Acked-by: Peter Zijlstra (Intel)