Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp575922imm; Wed, 20 Jun 2018 03:13:29 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKtinDPUagpycc8vGbTbywF3yFF8qenJP8E1fVS2mDs6u+TydKmAvPMyCR9EIk7xqCWebUE X-Received: by 2002:a62:86c3:: with SMTP id x186-v6mr22074110pfd.4.1529489609067; Wed, 20 Jun 2018 03:13:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529489609; cv=none; d=google.com; s=arc-20160816; b=SfHjyxlqq8SexGxNmML9JGqpVvGSrksHTD5XjJLJ2aAt1i3SLkg3hAwGHElQo3Aloy iENvw0rbV4s/tOMZmu39P8OYlbJZfl2axEPqOj7MWrKvFtOl68f4yufrjPjA6SRIuw+t BcZ075B3HHVVGRE0/iNp2swXG1qLHJeEDLbI0y7D8FQrNHRqo79XHsRHSOREacSo0J+S hQ05SCKRleFkTBH7siznPuB4ZddKU3hxSUTz7DmdmIMIQP+/bXFWQpcj5pebyWaI++Qj uotOcgna8RVJEXvRZ/0Zaca/+pjVitGhn5i3gtvd65UTsSNwWLmcr/0iE29aHZKeTD9G DVMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=wphsx1ie+vTTS1ccDffy8jDITyX2/OntPApbDAJa+rI=; b=bLvikruH93x9j8YbzfJ1LsfeS0+ueqown/XVTRC9yUrOg8WZMuDqF6Fx3n56xKCjsG pRfJ2bmf87wA5QDgYZtbc9dfBprgUJDDhV/fGO3fc+FoB4vE3yjqLF7+lcPkOD6mYeAs BFa6Ttwg3KNWd9iRJiLiSpaugJqx8k910MgV/I+1pThgK15jIdR76a12tknVK52QX86Q rwakW+yiDf0GWGySi3Df/wQ23WlS0Kd+OjQyRrqnXkYGLqzV/sMV/gu485TCCeHkfPjp W+9bhPyUvWr4rOsMwgA8LAVpDvwE4O4gobv4q3JGvFqNjt8ZZBwBFdNRqVF1P9vMtNQK TS8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=jQp64O6h; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u191-v6si1650542pgd.667.2018.06.20.03.13.14; Wed, 20 Jun 2018 03:13:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=jQp64O6h; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754172AbeFTKKb (ORCPT + 99 others); Wed, 20 Jun 2018 06:10:31 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:56072 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754138AbeFTKKa (ORCPT ); Wed, 20 Jun 2018 06:10:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wphsx1ie+vTTS1ccDffy8jDITyX2/OntPApbDAJa+rI=; b=jQp64O6htK4v7GaYkXTUApwU/ iJ0qhYXB6+ykubcjn5RvgNqK5J30xUwEdC9VNoRMhsALkpvrPmkuCqniLNd8fvxWwnrrghKP9J9VD MfuVVmiSdKgBopjqqYRI+hyQbkMcsxOvKj6SBCqvxurCJIah+0tQbMGaq9T20UpYv59Yg4TaVrhZL qnZsLLgI9BKDW/Xc61mrg4+YXELWHw/0qwpioB4pBOV0Fxycv3ytM9ZvTcnzbm1ZIw64GwEURL0Rc VGymFj/7sEaIC4m6m+XjXGHPY3q6Qc4gC0AJ9wn/isH6aSAtd1fqQ5QKqrdfIfUQUiE6CW5FV6w1C oXyvPMrsA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fVa4F-0001LX-Kg; Wed, 20 Jun 2018 10:10:23 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 68F4D2029FA0A; Wed, 20 Jun 2018 12:10:21 +0200 (CEST) Date: Wed, 20 Jun 2018 12:10:21 +0200 From: Peter Zijlstra To: Nadav Amit Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Alok Kataria , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , virtualization@lists.linux-foundation.org Subject: Re: [PATCH v5 6/9] x86: prevent inline distortion by paravirt ops Message-ID: <20180620101021.GA2530@hirez.programming.kicks-ass.net> References: <20180619194854.69486-1-namit@vmware.com> <20180619194854.69486-7-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180619194854.69486-7-namit@vmware.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 19, 2018 at 12:48:51PM -0700, Nadav Amit wrote: > +#define paravirt_alt \ > + "PARAVIRT_CALL type=\"%c[paravirt_typenum]\"" \ > + " clobber=\"%c[paravirt_clobber]\"" \ > + " pv_opptr=\"%c[paravirt_opptr]\"" That wants to be: + " pv_opptr=\"%c[paravirt_opptr]\";" And other than that I would suggest: 's/paravirt_alt/paravirt_call/g'.