Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] net: macb: Fix ptp time adjustment for large negative
 delta
To:     Harini Katakam <harini.katakam@xilinx.com>, <davem@davemloft.net>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <michal.simek@xilinx.com>, <harinikatakamlinux@gmail.com>,
        Claudiu Beznea - M18063 <Claudiu.Beznea@microchip.com>
References: <1529494460-4689-1-git-send-email-harini.katakam@xilinx.com>
From:   Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
Message-ID: <ff8fac12-b5a1-5e2d-e4f6-4ee68bf685a7@microchip.com>
Date:   Wed, 20 Jun 2018 16:04:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <1529494460-4689-1-git-send-email-harini.katakam@xilinx.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 20/06/2018 at 13:34, Harini Katakam wrote:
> When delta passed to gem_ptp_adjtime is negative, the sign is
> maintained in the ns_to_timespec64 conversion. Hence timespec_add
> should be used directly. timespec_sub will just subtract the negative
> value thus increasing the time difference.
> 
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>

Makes sense:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>   drivers/net/ethernet/cadence/macb_ptp.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_ptp.c b/drivers/net/ethernet/cadence/macb_ptp.c
> index 2220c77..6788351 100644
> --- a/drivers/net/ethernet/cadence/macb_ptp.c
> +++ b/drivers/net/ethernet/cadence/macb_ptp.c
> @@ -170,10 +170,7 @@ static int gem_ptp_adjtime(struct ptp_clock_info *ptp, s64 delta)
>   
>   	if (delta > TSU_NSEC_MAX_VAL) {
>   		gem_tsu_get_time(&bp->ptp_clock_info, &now);
> -		if (sign)
> -			now = timespec64_sub(now, then);
> -		else
> -			now = timespec64_add(now, then);
> +		now = timespec64_add(now, then);
>   
>   		gem_tsu_set_time(&bp->ptp_clock_info,
>   				 (const struct timespec64 *)&now);
> 


-- 
Nicolas Ferre