Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp851906imm; Wed, 20 Jun 2018 07:39:40 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJaFd1EKpmxqgZu6OunzaOQSiT16bYR2ucPYOkiFAoE6nyu6dd4Otq6N04ZnLpE7isWID9R X-Received: by 2002:a17:902:22:: with SMTP id 31-v6mr15834621pla.332.1529505580794; Wed, 20 Jun 2018 07:39:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529505580; cv=none; d=google.com; s=arc-20160816; b=xjSldiEHA8ktA4fS3XhLqywdoy3QafZUW0s/qn3JvgOrQhrfNGZBg8MN23bcQIgrbw G8YUm8USOF+bCthXSWwEgBw/YVKH882zs451AxJftMK6EeSaPhmT+wBXYqetriDLIPPM jpYJX73527Y+EnFE62zisZ+YUncpMd7VcwsQsRK8peiNt2/xr3DX5bNyJyzi4QrlXPQ1 I2HTl6DVYCOhnlUzDmSwOcWzBMF4NdgVoG9VA6SQ5Rj8gdkUeuvioBl7Efl5rm3sjGvU i0CtmXkosC0l9OR2cwhd/iplpGCTTr3KlfmJ3OJCtGQPJV6Mf2vmZkWD4Ul3RC2dBIi4 5wGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=WI6Q5bAfKWxt3Y0bIhpu9fFeYKL0cHKy5rPr8uPu3Qw=; b=L8vflhlPJyktsHS3krdjOE5lkimMXnJaQYSrBCF1GKSm0WflyLhusx3wPms8aT0Fp7 1Cn3TLHBL+7rDH8z49QEyPVyI+hocZRg2Laso33MeC9djQUN2qiGpu1pOhS7kNpvE9B7 a5201QwctB+h2EkhDmow5fce6Krob/r9IFuXSzEzE4pAJbiVOnpwMdFX5wT20NbbAc4T ii1uQRwi6avYHtS2ATSGimS6QG0XCkgYvcrt81KbdlooAGfZkAsZTrnrQ4lVwBNPE1ja Q7HXdCubE/0ua25E+ZqpN/rc/ORPwHJtOyYyO5qw/EURIZKTo7iFUi1JK9f9BsSYqBDz oEgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e88-v6si2588574pfk.198.2018.06.20.07.39.27; Wed, 20 Jun 2018 07:39:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754272AbeFTOi2 (ORCPT + 99 others); Wed, 20 Jun 2018 10:38:28 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:36224 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752932AbeFTOi1 (ORCPT ); Wed, 20 Jun 2018 10:38:27 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1fVeFR-00069V-0J; Wed, 20 Jun 2018 22:38:13 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1fVeFL-0000Y2-KD; Wed, 20 Jun 2018 22:38:07 +0800 Date: Wed, 20 Jun 2018 22:38:07 +0800 From: Herbert Xu To: "Maciej S. Szmigiero" Cc: David Howells , Tom Lendacky , Gary Hook , "David S. Miller" , james.morris@microsoft.com, "Serge E. Hallyn" , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2][RESEND] X.509: unpack RSA signatureValue field from BIT STRING Message-ID: <20180620143807.fo7c5endwd5yy24r@gondor.apana.org.au> References: <04f372f3-bc26-c629-2269-0e5d258f9d8f@maciej.szmigiero.name> <80e95323-eb7f-6af3-ad05-f174c69fb948@maciej.szmigiero.name> <9a9bfd23-d7be-7f16-925e-5fe00cbfba9f@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9a9bfd23-d7be-7f16-925e-5fe00cbfba9f@maciej.szmigiero.name> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 20, 2018 at 02:24:54PM +0200, Maciej S. Szmigiero wrote: > > A friendly ping here. > > @AMD people: > Without this patch, in-kernel X.509 certificate verification is broken > on AMD CCP RSA implementation. > > For example, loading wireless regulatory database gives the following > errors: > > [ 21.310361] cfg80211: Problem loading in-kernel X.509 certificate (-22) > > [ 21.351717] cfg80211: loaded regulatory.db is malformed or signature is missing/invalid > > Kernel modules signature verification probably has similar problem, too. > > That's why it would be nice if you could ack this patch, please. David/James, is there an issue with the patch? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt