Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1253241imm; Wed, 20 Jun 2018 14:29:30 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLVJN60cOG6Yue08dWS9C9USdd2+CkiZ3bVrd04M9O3mFXu8ovEcskp4edfgBnzO0svXdNi X-Received: by 2002:a17:902:6686:: with SMTP id e6-v6mr25536574plk.35.1529530170316; Wed, 20 Jun 2018 14:29:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529530170; cv=none; d=google.com; s=arc-20160816; b=tBuEh5tg9yDTpA71tILySYgRE1tAtvyi4blrUKZw5eogJHfTHjXSIHsRoPRE1qxd51 QdU1WD65LNp7dcNDXyz9OiSCQR2HnQA993bw89kfUuRM5k1qKzG2IOhHGbDHrl6opvZW Z9Yx+hbtAcrwRx1jQjQTwoBclRbnTLebm/rVAGt2qyz/HQXs/rO7QB+zuR3H2YH7iA9I XuLKkMaHLD4b7UB4e0i6OVz7qKpONH5BDyrrFF2TKuJCx6Gljvr91mffwx5AJKUFILJ1 jhWRBbMlNRnpsYJPjO5wGf2/PPeMyELdd7oHxxm7gYISFVg1L2/H6CQ91D9cN6tJI9jQ dYSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from :dkim-signature:arc-authentication-results; bh=Rc31RxZ84M1CfmBcvrBg/6AhWu5Oswy7j/kWflOjw1Y=; b=ducqe1SonjrROq2l0UP5VLfyPqsMGI1Ozdlb6ESroj2Tc6BtA9gFJwJNgo2yAbbM1S 9ReoinfPnHLlqNAvcaSDJ7MDq68QF6c3T/7tvN6C6qfZBIOb1TIZ85uj8tvhcStYVy+9 PeX0FTPIJhSKRb/XcnLTsWC2lHC8aEOdI6YfRMIN4XMLsP4M31yrapobyo3G5p0UkdeN L2oG5xfpavramDt8vPv59CduREjsUmJBXbSDsx7WVG1HMkkUcW566ckdNc+JLVS0Ew2t hoQg70i4OKIvkjEpU0zw1SZ820x8Fwcgkl1MhY7f/pA4vIeqM8y1jyXfc+EuQY5PKTto gSjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=mgOTohEa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d5-v6si3156357plo.3.2018.06.20.14.29.16; Wed, 20 Jun 2018 14:29:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=mgOTohEa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933482AbeFTV2V (ORCPT + 99 others); Wed, 20 Jun 2018 17:28:21 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:48744 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933115AbeFTV2S (ORCPT ); Wed, 20 Jun 2018 17:28:18 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w5KLOXIH065881; Wed, 20 Jun 2018 21:27:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id; s=corp-2017-10-26; bh=Rc31RxZ84M1CfmBcvrBg/6AhWu5Oswy7j/kWflOjw1Y=; b=mgOTohEaoqYdcEasULOto2UFLnv5VNzV7CyhETTG2qpgMMO1tOT9tOIDXi0YXJR+xUZY PtmIh0fAiDQFQnMxMosVlN/o1PUTjKf8L1iIu/GiEw6/cQRixaZhbNnhLXG1eXb3BeBW H+Dip56hOMwkOSlAKJV/e/NtpHemQJAMsRtzXTODroaxsI16O+Nzy4mBWty0mayP0V1i b5asp5p9/TI+El+jiANVUMPRYYOibMTz71ZyrGtlQHFYTbY/AC9Lho0afYhiqRHU1vkX Rn5Lwzsl/6JnpaiD4BgfVfw0pJpQl9ks2Wpdv9s4pxbDkgY6Oxys7ubbpMEoSEPIPD6P oQ== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2jmtgwxa3p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Jun 2018 21:27:09 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w5KLR8Jn013299 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Jun 2018 21:27:08 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w5KLR5bG026904; Wed, 20 Jun 2018 21:27:06 GMT Received: from xakep.us.oracle.com (/10.39.216.167) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 20 Jun 2018 14:27:05 -0700 From: Pavel Tatashin To: steven.sistare@oracle.com, daniel.m.jordan@oracle.com, linux@armlinux.org.uk, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, john.stultz@linaro.org, sboyd@codeaurora.org, x86@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, douly.fnst@cn.fujitsu.com, peterz@infradead.org, prarit@redhat.com, feng.tang@intel.com, pmladek@suse.com, gnomes@lxorguk.ukuu.org.uk Subject: [PATCH v11 0/6] Early boot time stamps for x86 Date: Wed, 20 Jun 2018 17:26:54 -0400 Message-Id: <20180620212700.29178-1-pasha.tatashin@oracle.com> X-Mailer: git-send-email 2.17.1 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8930 signatures=668702 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1806200231 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org changelog --------- v11 - v10 - Addressed all the comments from Thomas Gleixner. - I added one more patch: "x86/tsc: prepare for early sched_clock" which fixes a problem that I discovered while testing. I am not particularly happy with the fix, as it adds a new argument that is used only in one place, but if you have a suggestion for a different approach on how to address this problem please let me know. v10 - v9 - Added another patch to this series that removes dependency between KVM clock, and memblock allocator. The benefit is that all clocks can now be initialized even earlier. v9 - v8 - Addressed more comments from Dou Liyang v8 - v7 - Addressed comments from Dou Liyang: - Moved tsc_early_init() and tsc_early_fini() to be all inside tsc.c, and changed them to be static. - Removed warning when notsc parameter is used. - Merged with: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git v7 - v6 - Removed tsc_disabled flag, now notsc is equivalent of tsc=unstable - Simplified changes to sched/clock.c, by removing the sched_clock_early() and friends as requested by Peter Zijlstra. We know always use sched_clock() - Modified x86 sched_clock() to return either early boot time or regular. - Added another example why ealry boot time is important v5 - v6 - Added a new patch: time: sync read_boot_clock64() with persistent clock Which fixes missing __init macro, and enabled time discrepancy fix that was noted by Thomas Gleixner - Split "x86/time: read_boot_clock64() implementation" into a separate patch v4 - v5 - Fix compiler warnings on systems with stable clocks. v3 - v4 - Fixed tsc_early_fini() call to be in the 2nd patch as reported by Dou Liyang - Improved comment before __use_sched_clock_early to explain why we need both booleans. - Simplified valid_clock logic in read_boot_clock64(). v2 - v3 - Addressed comment from Thomas Gleixner - Timestamps are available a little later in boot but still much earlier than in mainline. This significantly simplified this work. v1 - v2 In patch "x86/tsc: tsc early": - added tsc_adjusted_early() - fixed 32-bit compile error use do_div() The early boot time stamps were discussed recently in these threads: http://lkml.kernel.org/r/1527672059-6225-1-git-send-email-feng.tang@intel.com http://lkml.kernel.org/r/1527672059-6225-2-git-send-email-feng.tang@intel.com I updated my series to the latest mainline and sending it again. Peter mentioned he did not like patch 6,7, and we can discuss for a better way to do that, but I think patches 1-5 can be accepted separetly, since they already enable early timestamps on platforms where sched_clock() is available early. Such as KVM. Adding early boot time stamps support for x86 machines. SPARC patches for early boot time stamps are already integrated into mainline linux. Sample output ------------- Before: https://paste.ubuntu.com/26133428/ After: https://paste.ubuntu.com/26133523/ For exaples how early time stamps are used, see this work: Example 1: https://lwn.net/Articles/734374/ - Without early boot time stamps we would not know about the extra time that is spent zeroing struct pages early in boot even when deferred page initialization. Example 2: https://patchwork.kernel.org/patch/10021247/ - If early boot timestamps were available, the engineer who introduced this bug would have noticed the extra time that is spent early in boot. Pavel Tatashin (7): x86/tsc: remove tsc_disabled flag time: sync read_boot_clock64() with persistent clock x86/time: read_boot_clock64() implementation sched: early boot clock kvm/x86: remove kvm memblock dependency x86/paravirt: add active_sched_clock to pv_time_ops x86/tsc: use tsc early Example 3: http://lkml.kernel.org/r/20180615155733.1175-1-pasha.tatashin@oracle.com - Needed early time stamps to show improvement Pavel Tatashin (6): x86/tsc: redefine notsc to behave as tsc=unstable kvm/x86: remove kvm memblock dependency time: replace read_boot_clock64() with read_persistent_wall_and_boot_offset() x86/tsc: prepare for early sched_clock. sched: early boot clock x86/tsc: use tsc early .../admin-guide/kernel-parameters.txt | 2 - Documentation/x86/x86_64/boot-options.txt | 4 +- arch/arm/kernel/time.c | 12 +-- arch/s390/kernel/time.c | 11 ++- arch/x86/kernel/kvm.c | 1 + arch/x86/kernel/kvmclock.c | 64 ++----------- arch/x86/kernel/setup.c | 7 +- arch/x86/kernel/tsc.c | 89 +++++++++++-------- include/linux/timekeeping.h | 3 +- kernel/sched/clock.c | 10 ++- kernel/time/timekeeping.c | 61 +++++++------ 11 files changed, 117 insertions(+), 147 deletions(-) -- 2.17.1