Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1286241imm; Wed, 20 Jun 2018 15:10:26 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIwI9WPVTWGGVLGyMo2+AcM5AhvReCYZ6dbcO7oqO0H4SEqGEyfcTQjkHoEIjLxk3nskNos X-Received: by 2002:a63:a347:: with SMTP id v7-v6mr646203pgn.182.1529532626727; Wed, 20 Jun 2018 15:10:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529532626; cv=none; d=google.com; s=arc-20160816; b=e1Y883BBKThw0Dm7i3NrG2mH6HeIOQq5N2ByaIb9MBUuIwZmEUwd3I7nKDsjJ2091w bZXMrpCwiDHghzrI8+Q/piAc71PZc2TNdINEom+9kLzTAv0nas73bw2c0sJTta4uEHpZ ZCboe6+739eMRM8yr2N2otSSEHheEl16004Y7v2Ip+ZSGU8N5R0I9eu4PleykwZth5rw 76dRVeLDrmzJXfUBH5CPu4NCl4sgTGHPengFYJHbQ0f6DsqxSmdj6QcG+u8NXSd/pByP Giu/1Bx4ZerXfsTyKQCipug4uYljWsKLLLU0M3vHBnalJ3gRKZ9PBDkbKLWHtazMiXFo sXcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=mR5HnPNMgibQtvWRnsWtuYDgNYnMab1RfT1n7aFlQOM=; b=bUl+uCXHgbA9sAao4/1kY2063Han2eWLrMV3KgpXf/R4v+2FKMeVjSu7U7D627zCZL h3hXh1DQEruMnhnQkFGzVKc7xAB0ISlzFZINGHKmOLffHhkfLq0qfsfvTMax1m3HBR02 gtv5g6OUMtwHhgte5BYEMTpZM2oPLUMBhr3sPi7c8flkqUFqyp6SVZGWC21DL8XehmSC JT0sK2bAkNNM6V3+tyLwZN5HRc62hkrkCTEo4N3uVG3cdu4lcFBUpWVyvUhJ/vCW5Qra KyP4Tlkgf5yY2qrGA2JfGEsQsD+S1SprO015YhrRoOpY3V5ZCcrmt6NevwSamYRvOWyQ vNyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m12-v6si3236752pfd.348.2018.06.20.15.10.12; Wed, 20 Jun 2018 15:10:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933658AbeFTWJe (ORCPT + 99 others); Wed, 20 Jun 2018 18:09:34 -0400 Received: from mga01.intel.com ([192.55.52.88]:19370 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933249AbeFTWJb (ORCPT ); Wed, 20 Jun 2018 18:09:31 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2018 15:09:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,249,1526367600"; d="scan'208";a="66312710" Received: from linksys13920.jf.intel.com (HELO rpedgeco-HP-Z240-Tower-Workstation.jf.intel.com) ([10.7.197.56]) by orsmga001.jf.intel.com with ESMTP; 20 Jun 2018 15:09:31 -0700 From: Rick Edgecombe To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-hardening@lists.openwall.com Cc: kristen.c.accardi@intel.com, dave.hansen@intel.com, arjan.van.de.ven@intel.com, Rick Edgecombe Subject: [PATCH 1/3] vmalloc: Add __vmalloc_node_try_addr function Date: Wed, 20 Jun 2018 15:09:28 -0700 Message-Id: <1529532570-21765-2-git-send-email-rick.p.edgecombe@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1529532570-21765-1-git-send-email-rick.p.edgecombe@intel.com> References: <1529532570-21765-1-git-send-email-rick.p.edgecombe@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Create __vmalloc_node_try_addr function that tries to allocate at a specific address. The implementation relies on __vmalloc_node_range for the bulk of the work. To keep this function from spamming the logs when an allocation failure is fails, __vmalloc_node_range is changed to only warn when __GFP_NOWARN is not set. This behavior is consistent with this flags interpretation in alloc_vmap_area. Signed-off-by: Rick Edgecombe --- include/linux/vmalloc.h | 3 +++ mm/vmalloc.c | 41 +++++++++++++++++++++++++++++++++++++++-- 2 files changed, 42 insertions(+), 2 deletions(-) diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h index 398e9c9..6eaa896 100644 --- a/include/linux/vmalloc.h +++ b/include/linux/vmalloc.h @@ -82,6 +82,9 @@ extern void *__vmalloc_node_range(unsigned long size, unsigned long align, unsigned long start, unsigned long end, gfp_t gfp_mask, pgprot_t prot, unsigned long vm_flags, int node, const void *caller); +extern void *__vmalloc_node_try_addr(unsigned long addr, unsigned long size, + gfp_t gfp_mask, pgprot_t prot, unsigned long vm_flags, + int node, const void *caller); #ifndef CONFIG_MMU extern void *__vmalloc_node_flags(unsigned long size, int node, gfp_t flags); static inline void *__vmalloc_node_flags_caller(unsigned long size, int node, diff --git a/mm/vmalloc.c b/mm/vmalloc.c index cfea25b..9e0820c9 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1710,6 +1710,42 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, } /** + * __vmalloc_try_addr - try to alloc at a specific address + * @addr: address to try + * @size: size to try + * @gfp_mask: flags for the page level allocator + * @prot: protection mask for the allocated pages + * @vm_flags: additional vm area flags (e.g. %VM_NO_GUARD) + * @node: node to use for allocation or NUMA_NO_NODE + * @caller: caller's return address + * + * Try to allocate at the specific address. If it succeeds the address is + * returned. If it fails NULL is returned. It may trigger TLB flushes. + */ +void *__vmalloc_node_try_addr(unsigned long addr, unsigned long size, + gfp_t gfp_mask, pgprot_t prot, unsigned long vm_flags, + int node, const void *caller) +{ + unsigned long addr_end; + unsigned long vsize = PAGE_ALIGN(size); + + if (!vsize || (vsize >> PAGE_SHIFT) > totalram_pages) + return NULL; + + if (!(vm_flags & VM_NO_GUARD)) + vsize += PAGE_SIZE; + + addr_end = addr + vsize; + + if (addr > addr_end) + return NULL; + + return __vmalloc_node_range(size, 1, addr, addr_end, + gfp_mask | __GFP_NOWARN, prot, vm_flags, node, + caller); +} + +/** * __vmalloc_node_range - allocate virtually contiguous memory * @size: allocation size * @align: desired alignment @@ -1759,8 +1795,9 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align, return addr; fail: - warn_alloc(gfp_mask, NULL, - "vmalloc: allocation failure: %lu bytes", real_size); + if (!(gfp_mask & __GFP_NOWARN)) + warn_alloc(gfp_mask, NULL, + "vmalloc: allocation failure: %lu bytes", real_size); return NULL; } -- 2.7.4