Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1405242imm; Wed, 20 Jun 2018 17:55:41 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKsvaRaOLB7AJZakg3tBqEM22tGX6LNuO5nH3wQK6srf9ARYbgwkyoYq8Dtftr4/Jc+PW5R X-Received: by 2002:a17:902:4545:: with SMTP id m63-v6mr26412432pld.268.1529542541183; Wed, 20 Jun 2018 17:55:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529542541; cv=none; d=google.com; s=arc-20160816; b=dWG9TgLK2S8vWSdWTEwdMLk7MdpHWornz1w6ZTGYLcz++/yHkJgTMy6uFw7AXiiHsG Zd5J/y8Qhq3/PXg4QUONw997JBReK1q//kD2CHJbjxXPqG0bedOdYJZXrtkIyxXeg8Dd oOdt8dLdqKEgwzbXub8NsnxcKRMS7VAjtivrD3M/Wq5yH1OwdGR75TBm8fqkF6ER19Ah In8jzCVI5cXbKNi7lQAoJ2gT/oZQ0e4plr1ijBB/9nm4Z3kA1XWKPnmmDwk3wrUA7MVP ipPPQNbDNPtT+kZB7KC10DhoCgFXP20TosTDDVh9aKp/bI8449zOU2s5qNBSXbb2sMqD 5Wrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=e0G1mLpSCS4d6psIQQOFjUIeJ6PHHXlrpDBHDbpsfo0=; b=uL6m9X8MRU6ZocnWF+5Z1FEHBLc2+dkiLd0JepVOBrGkRZRBh44eoBYKD/kvfWG5D7 DQcBv4vEbK8JicwAduMsEdmN2UDi2rdkdADEv0tq5NWI9B7ixMR8auDoVHmT4X+ksoiM v3NE9E385emq0pH85+lonUTJsWYCwdgGb/ia1T9uafrQ2OR9aBHwZmraDUzOw0IYQpIl 24pbZCarZR4uPMdpLohi8KT/BKO0MJdxNkQFG5hWpuMFWl+wb0+Nwb7Eomj88VxK92LC WjMJLv4bROFyo9ZLH5TByYPmwpbcioxdiv1FCxjwEYpeeFPVrU/sodHSlQ00MO1FCjB3 bqVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m13-v6si3298431pfh.92.2018.06.20.17.55.27; Wed, 20 Jun 2018 17:55:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754559AbeFUAy0 (ORCPT + 99 others); Wed, 20 Jun 2018 20:54:26 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:46202 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754517AbeFUAyY (ORCPT ); Wed, 20 Jun 2018 20:54:24 -0400 Received: from localhost (unknown [61.102.160.122]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 23A35147040AA; Wed, 20 Jun 2018 17:54:21 -0700 (PDT) Date: Thu, 21 Jun 2018 09:54:18 +0900 (KST) Message-Id: <20180621.095418.39855891010040022.davem@davemloft.net> To: vakul.garg@nxp.com Cc: doronrk@fb.com, tom@quantonium.net, john.fastabend@gmail.com, davejwatson@fb.com, netdev@vger.kernel.org, ebiggers@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net][RESEND] strparser: Don't schedule in workqueue in paused state From: David Miller In-Reply-To: <20180620215949.32334-1-vakul.garg@nxp.com> References: <20180620215949.32334-1-vakul.garg@nxp.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 20 Jun 2018 17:54:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vakul Garg Date: Thu, 21 Jun 2018 03:29:49 +0530 > In function strp_data_ready(), it is useless to call queue_work if > the state of strparser is already paused. The state checking should > be done before calling queue_work. The change reduces the context > switches and improves the ktls-rx throughput by approx 20% (measured > on cortex-a53 based platform). > > Signed-off-by: Vakul Garg Applied, thank you.