Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180620125540.228766-1-dvyukov@gmail.com>
References: <20180620125540.228766-1-dvyukov@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 21 Jun 2018 04:06:05 +0300
Message-ID: <CAHp75VdR_gDBk7v9WDN1fHc=1q=j2mx3CkTz83SZZWm=pbnczA@mail.gmail.com>
Subject: Re: [PATCH] arch/x86: get rid of KERN_CONT in show_fault_oops()
To:     Dmitry Vyukov <dvyukov@gmail.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 20, 2018 at 3:55 PM, Dmitry Vyukov <dvyukov@gmail.com> wrote:
> From: Dmitry Vyukov <dvyukov@google.com>
>
> KERN_CONT leads to split lines in kernel output
> and complicates useful changes to printk like
> printing context before each line.
>
> Only acceptable use of continuations is basically
> boot-time testing.
>
> Get rid of it.

> +       printk(KERN_ALERT "BUG: unable to handle kernel %s at %px\n",
> +               (address < PAGE_SIZE ? "NULL pointer dereference" :
> +               "paging request"), (void *) address);

Perhaps pr_alert() ?

Btw, parens are redundant for the first argument.

P.S. And personally I would rather do
if (address < PAGE_SIZE)
 pr_alert(...NULL pointer dereference...);
else
 pr_alert(...paging request...);

-- 
With Best Regards,
Andy Shevchenko