Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/2] fs/exofs: fix potential memory leak in mount option
 parsing
To:     ooo@electrozaur.com
Cc:     linux-kernel@vger.kernel.org, cgxu519@gmx.com
References: <1528862714-78150-1-git-send-email-cgxu519@gmx.com>
From:   cgxu519 <cgxu519@gmx.com>
Message-ID: <38b17aef-db48-0258-3086-206659d2da85@gmx.com>
Date:   Thu, 21 Jun 2018 10:14:47 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <1528862714-78150-1-git-send-email-cgxu519@gmx.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Boaz,

Could you have a look at this trivial patch?

Thanks,
Chengguang.

On 06/13/2018 12:05 PM, Chengguang Xu wrote:
> There are some cases can cause memory leak when parsing
> option 'osdname'.
>
> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
> ---
>   fs/exofs/super.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/fs/exofs/super.c b/fs/exofs/super.c
> index 719a315..f3e17a9 100644
> --- a/fs/exofs/super.c
> +++ b/fs/exofs/super.c
> @@ -101,6 +101,7 @@ static int parse_options(char *options, struct exofs_mountopt *opts)
>   		token = match_token(p, tokens, args);
>   		switch (token) {
>   		case Opt_name:
> +			kfree(opts->dev_name);
>   			opts->dev_name = match_strdup(&args[0]);
>   			if (unlikely(!opts->dev_name)) {
>   				EXOFS_ERR("Error allocating dev_name");
> @@ -867,8 +868,10 @@ static struct dentry *exofs_mount(struct file_system_type *type,
>   	int ret;
>   
>   	ret = parse_options(data, &opts);
> -	if (ret)
> +	if (ret) {
> +		kfree(opts.dev_name);
>   		return ERR_PTR(ret);
> +	}
>   
>   	if (!opts.dev_name)
>   		opts.dev_name = dev_name;