Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] nilfs2: use 64-bit superblock timstamps
References: <20180620075041.4154396-1-arnd@arndb.de>
From:   Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Organization: NTT OSS Center
Message-ID: <57ac1977-b060-77b1-61a5-8e7b690e162d@lab.ntt.co.jp>
Date:   Thu, 21 Jun 2018 11:41:26 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180620075041.4154396-1-arnd@arndb.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
To:     Arnd Bergmann <arnd@arndb.de>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     y2038@lists.linaro.org, David Howells <dhowells@redhat.com>,
        Jeff Layton <jlayton@redhat.com>, linux-nilfs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018/06/20 16:50, Arnd Bergmann wrote:
> The mount time field in the superblock uses a 64-bit timestamp, but
> calling get_seconds() may truncate the current time to 32 bits.
> 
> This changes it to ktime_get_real_seconds() to avoid the potential
> overflow.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Looks good to me.

Thanks, all.

Acked-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>


> ---
>   fs/nilfs2/super.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c
> index 6ffeca84d7c3..1b9067cf4511 100644
> --- a/fs/nilfs2/super.c
> +++ b/fs/nilfs2/super.c
> @@ -834,7 +834,7 @@ static int nilfs_setup_super(struct super_block *sb, int is_mount)
>   		sbp[0]->s_max_mnt_count = cpu_to_le16(NILFS_DFL_MAX_MNT_COUNT);
>   
>   	sbp[0]->s_mnt_count = cpu_to_le16(mnt_count + 1);
> -	sbp[0]->s_mtime = cpu_to_le64(get_seconds());
> +	sbp[0]->s_mtime = cpu_to_le64(ktime_get_real_seconds());
>   
>   skip_mount_setup:
>   	sbp[0]->s_state =
>