Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1643306imm; Wed, 20 Jun 2018 23:43:58 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJ0Z4h7ngJigGA62Vwcy32IAM0xXn6sy8mo3al/pufKt2AuZbsqy6Yt+waUkSYb5QWzOeAL X-Received: by 2002:a17:902:343:: with SMTP id 61-v6mr26961889pld.344.1529563438141; Wed, 20 Jun 2018 23:43:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529563438; cv=none; d=google.com; s=arc-20160816; b=kT0ToojYzQ2wj1PG7cWHQCt4PQwUM3EsmIKDr3LsYEwB3skwQUrS4d9+SbIOLX9wa2 0oPf9sxS7dUqxShGp5K1kXFOHMP88BsOYBKGTKB1QMAi7O3w8am2V4uSJ5qHn5xYRVfY 60Gvsz5tSUnnxouXQGG11B671nbgEFjiG24FkeNADjLCAbm7VEhVjF1L17ZVjeyfOA0G 1Z3zHjMS3U0MEfpdHj0Lu3+PpJRnm3aWIpW7EYlCFjLTYY2CBkMw5WEDe8uiwpGkbktI GGJeinLtKUKTmtT0ciVY9pnbd8579TeAAL+np6l9sfnn2Rm9U324KpfKLKMO4MnXf22x Gi2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=4fzL+BRh8IfVJQYasBAcv95DF1JHLlYLCZ0mGflOQCw=; b=ohNmbg74ThohgAoc7ZJbC3MZ+sL4Jh88Dco/RYkZI0U5Fg05ymqqA8TuVNwQS54/Nr biTykGTsnhApylRuaqM2avTD7AZC6/bKQ2BpqLRK/d1fwYbJrlLiTnXD8cEkCp9ia6n6 yuKYNceaZiOpx5jMNOvX15VsUkABrPSbdjRvkGoUv90tXeqhrhtgMx47aXyzog5fPaxf QeN5lBoTsiCnk4n6wg3f5V5lwiJ2Rm6ISBwu7ygO711JIO/zyaZVbBNZTR3eptHgemlG Ggrw0QEu8Vsjcxz9nmDCPmJUJyzE4yA4Qvg2H3HJBp1cXmBC+0OsiMP/6k8l4kYOoKGT hPeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=IpX+aPGV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s3-v6si3938932plb.394.2018.06.20.23.43.44; Wed, 20 Jun 2018 23:43:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=IpX+aPGV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932501AbeFUGli (ORCPT + 99 others); Thu, 21 Jun 2018 02:41:38 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:35542 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751321AbeFUGlh (ORCPT ); Thu, 21 Jun 2018 02:41:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4fzL+BRh8IfVJQYasBAcv95DF1JHLlYLCZ0mGflOQCw=; b=IpX+aPGVfCPIjYS2DH75eg/RW oOt8N3CplUqdg+RtIDRqrg5bGdNFSgRtaAE5HTYTkZ1cG4A+NhBM2cAy+iHLHZZEfjtmNLJ8AEeIx QZjllryLRsqTl5pD4MFOTuZwoXy3K89BTrMPD6X88pBmYpOH2LJBUi2nJ8yuqPPxVSi4vtRLKzxT8 d5xBhwrgcB4Fnd2/wWtXEO/UiPmKi3t1T8j9oXNDSQRqeqmqlq38snoOZwDmIggUK8fOXzccZOlCi FIgnM1YFsnp6k6+f7vroVUnpCQbCutaSEjFvfZTi8eaYr56sQQw/7eC8/spswEVDROPCUDN1s/uE/ RQxajHxUA==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fVtHk-0003xd-6F; Thu, 21 Jun 2018 06:41:36 +0000 Date: Wed, 20 Jun 2018 23:41:35 -0700 From: Christoph Hellwig To: Zong Li Cc: palmer@sifive.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, greentime@adnestech.com Subject: Re: [PATCH 4/5] RISC-V: Change variable type for 32-bit compatible Message-ID: <20180621064135.GD19319@infradead.org> References: <3f86f9eb853380686a86a8abe6bda0dd3720ee10.1529506497.git.zong@andestech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f86f9eb853380686a86a8abe6bda0dd3720ee10.1529506497.git.zong@andestech.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > - s64 offset = (void *)v - (void *)location; > + uintptr_t offset = (void *)v - (void *)location; s64 is signed, uintptr is not, so this might change behavior and needs an explanation.