Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Dirk Gouders <dirk@gouders.net>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Masahiro Yamada <yamada.masahiro@socionext.com>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Segher Boessenkool <segher@kernel.crashing.org>,
        Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [RFC v8 1/1] mconf: global i-search in menu prompts
In-Reply-To: <126839db-5cc1-7dad-5a1f-21899dc6236e@infradead.org> (Randy
        Dunlap's message of "Wed, 20 Jun 2018 13:02:03 -0700")
References: <20180620084217.8597-1-dirk@gouders.net>
        <20180620084217.8597-2-dirk@gouders.net>
        <f02cc7c6-d92e-24f3-b0ad-df9e6bf7630a@infradead.org>
        <ghpo0l2spo.fsf@lena.gouders.net>
        <126839db-5cc1-7dad-5a1f-21899dc6236e@infradead.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)
Date:   Thu, 21 Jun 2018 08:57:12 +0200
Message-ID: <ghin6clj93.fsf@lena.gouders.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Randy Dunlap <rdunlap@infradead.org> writes:

> On 06/20/2018 11:55 AM, Dirk Gouders wrote:
>> Randy Dunlap <rdunlap@infradead.org> writes:
>> 
>>> Hi,
>>>
>>> On 06/20/2018 01:42 AM, Dirk Gouders wrote:
>>>>
>>>> Operation
>>>> ---------
>>>> The TAB key is reserved to toggle the focus between menu and bottons.
>>>> Focus is on the buttons if one of the buttens (the active one) is
>>>> hightlighted, otherwise it is on the menu.
>>>>
>>>> When the focus is on the buttons, mconf operates as before with the
>>>> exception of the TAB key.
>>>>
>>>> When the focus is on the menu, mconf operates in i-search mode and the
>>>> following input has special meaning:
>>>>
>>>> * <\> (backslash) can be used to search for other occurences of an
>>>>   already entered string.  On empty search strings, nothing happens.
>>>>
>>>> * Any other printable character than backslash and '\n' is appended to
>>>>   the current search string and a match is searched for.  If a match
>>>>   is found, it is immediately navigated to.
>>>
>>> About that paragraph above:  I tried to search for "fs-cache", as in:
>>>
>>> config FSCACHE_DEBUG
>>> 	bool "Debug FS-Cache"
>>>
>>> but i-search does not allow me to enter a '-' character.  Seems odd to me.
>> 
>> Hi Randy,
>> 
>> thanks for all your testing.
>> 
>> '-' and '+' previously had the same meaning as <KEY_UP>, <KEY_DOWN>,
>> respectively.  If you are on the top menu item and press '-' there is
>> nothing to scroll up so it appears as if the pressed key wasn't
>> processed.
>> 
>> I-search should add those characters to the pattern but I broke that two
>> or three versions before when I fixed another issue.
>> 
>> I will add this to my list of test cases so this won't happen again.
>> 
>> Dirk
>> 
>> 
>>> Still doing other testing...
>
> I haven't hit any other issues.

Thank you for testing!
The issue concerning '-' and '+' I will fix.

Dirk