Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <cover.1529506497.git.zong@andestech.com> <3f86f9eb853380686a86a8abe6bda0dd3720ee10.1529506497.git.zong@andestech.com>
 <20180621064135.GD19319@infradead.org>
In-Reply-To: <20180621064135.GD19319@infradead.org>
From:   Zong Li <zongbox@gmail.com>
Date:   Thu, 21 Jun 2018 15:12:45 +0800
Message-ID: <CA+ZOyah0-d3diK2iaWXsoPsCS9T8pTfp5-gxOixfBvJYRVjdLQ@mail.gmail.com>
Subject: Re: [PATCH 4/5] RISC-V: Change variable type for 32-bit compatible
To:     hch@infradead.org
Cc:     Zong Li <zong@andestech.com>, linux-riscv@lists.infradead.org,
        Palmer Dabbelt <palmer@sifive.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        aou@eecs.berkeley.edu, greentime@adnestech.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > -     s64 offset = (void *)v - (void *)location;
> > +     uintptr_t offset = (void *)v - (void *)location;
>
> s64 is signed, uintptr is not, so this might change behavior and needs
> an explanation.
>

Yes, it should be intptr_t. Thanks!