Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1765629imm; Thu, 21 Jun 2018 01:54:35 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLLxGhN4ZvJPaoRLIIpq51C3UrXx+EpXHZ/P2Qze0w64hbjG+Rvvf5kWq/yEceh9jPA7uLj X-Received: by 2002:a17:902:6b05:: with SMTP id o5-v6mr5644512plk.67.1529571275474; Thu, 21 Jun 2018 01:54:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529571275; cv=none; d=google.com; s=arc-20160816; b=VaLZ283+FZMcq1kYfmNK3Ff/DQPFNvp0xfTZMvrDfD6X4VVPQHorw0DgIxrjK8JK6r fMVbkbIsmYtlkkw5RnjlK/yB2HGeltA2PE/K5+t6Iaa1RXNogy/L+Ipnn19lhhyRDG30 72u4c9GzjGko7fjdQK1Xbj4PjmvAgSrq4MPfvG1rIJJZN8y0v3YmgdVwhiYAWCViKGJN kp0vsWMyeyDzIqknZPcG03wz4QrDTLyBx66t7m3pI1wxgdU/yR0zc0WKQcHj9begy9ax XMTGvkeXxRk7lJL4jdj4xccbzPOTXiei8UQf/Y9mLxr1nK2uMJmX8u1LRuRwMcBfYlDt DTxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=A+VGHNT9g51lZJAFNCZYdM3q2ilAYXX/TQNr5yNiHyM=; b=exAw08oEJ7JxxdC4dY8d8a/4WXgqVlsMb5Ww5lrh3gLhvT3v43IiCfuLHEEUB2+fI7 5m3x2LStsajgJvbzzr/gPiSXG8vq0XMb1dSuXURU1tRgvEwFuVtex9+dLY2wjMxP+aCC pyFkKVUUkW72pI4cUCBAJiLHc4f8x+KG/FfMtvjkani/slRG0vxZ3ofIcmNoY8elH7gR aqGZ8VFBOp3cFgKdDVwhhSXWdtqZOeMo7Xs2sMy+5IFrkKT6pXVNo5+UdeOTAd3e5W8f /pz3RsQ0cwYIFcikUxL81c7/QUj1zd0ytnfXIjfQPBxff8DH4wxXObTo/IPEAsZOxkjQ ty4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o9-v6si4230454plk.434.2018.06.21.01.54.21; Thu, 21 Jun 2018 01:54:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754240AbeFUIxg (ORCPT + 99 others); Thu, 21 Jun 2018 04:53:36 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:48827 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754178AbeFUIxf (ORCPT ); Thu, 21 Jun 2018 04:53:35 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 8B47680554; Thu, 21 Jun 2018 10:53:33 +0200 (CEST) Date: Thu, 21 Jun 2018 10:53:33 +0200 From: Pavel Machek To: Chen Yu Cc: "Rafael J. Wysocki" , Len Brown , "Lee, Chun-Yi" , Borislav Petkov , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3][RFC] Introduce the in-kernel hibernation encryption Message-ID: <20180621085332.GA21807@amd> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="X1bOJ3K7DJ5YkBrT" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --X1bOJ3K7DJ5YkBrT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > As security becomes more and more important, we add the in-kernel > encryption support for hibernation. =2E.. > There was a discussion on the mailing list on whether this key should > be derived in kernel or in user space. And it turns out to be generating > the key by user space is more acceptable[1]. So this patch set is divided > into two parts: > 1. The hibernation snapshot encryption in kernel space, > 2. the key derivation implementation in user space. uswsusp was created so that this kind of stuff could be kept in userspace. You get graphical progress bar (etc) too. As you already have userspace component for key derivation, I see no advantages to uswsusp. If you have some, please explain. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --X1bOJ3K7DJ5YkBrT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlsrZ4wACgkQMOfwapXb+vJZqQCgkly9SD276j3k5iMXoRJ79poD UusAoKGQUGD1m96jkOVVxTiFwHuFCNYe =iseQ -----END PGP SIGNATURE----- --X1bOJ3K7DJ5YkBrT--