Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1811742imm;
        Thu, 21 Jun 2018 02:49:37 -0700 (PDT)
X-Google-Smtp-Source: ADUXVKJo8BgZ5k8y3v3B5n8O5JjboCsB7TBzW3kTggvyD9ES18JocdTyH9Sz9xV/+aeN99IOKzgZ
X-Received: by 2002:a62:b612:: with SMTP id j18-v6mr26799635pff.199.1529574577731;
        Thu, 21 Jun 2018 02:49:37 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1529574577; cv=none;
        d=google.com; s=arc-20160816;
        b=MCVFCdXLjTVvglEgb/y5TFGvvU4xdMbeUe66gz6LHz1QmQ8oanIcM0Mpsy+QVFzIxg
         V4CcqFKK3TwKhqyBhzmvj2kyuIQQtixeWKVs4uOHd/XpTcGbeEGtfoh6quDw5r+RHaEt
         QlbQPfyaAXNm8hi3CQLwBkZBl+h9Qh5fXeTyiYOqhStMJ1gf7nnNroTQQqM8eX+38Tt/
         p1s4sw7uame93MPwntZxC4S5Y2Mc0OpIEg9WYfFVdDC7XMJ2I03XSYW+7PQBwluSsn3m
         5r4FiCiZWulYbCkqd+zEh+q6+DXpUMZfmC0+bmvFdVarge+aXK03DZjzZcst1TE3gMm7
         CriQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject:arc-authentication-results;
        bh=z5DBBRvZC2I6Z7h5v6bV8AterjPHDiTo32DBURjzA5o=;
        b=ziqhElgNefsNflR2xVlbmJQlUgK3y9PZkLxgRFSO75BtImpVOf7cyf3fNdjU2lp9hY
         qoSXGulYroUA+bzP9w0qJYfIs0CVLl/NWsdtOW2o/aookeoCvM9WIohjgl9l3ntRVFn6
         uG+HWGaTJx+iPOBP8NIlvu+KSM23JRy51UqkFIQmOjkY/TboHOmYBqnwvLnOyOE8X+Cx
         O7BrQnEjVX1hRssHflNufW4UGYKgfUT1wgRb4OSLmRsDwK8+M32W9JU6vZOtYiHRV0cL
         44y6zMaBhtoOAod9oyRwjA3rUdMx0DgsuJ0gRCdsi/magGHNWQgwctdgyhQa6vxlGs00
         kYtA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id o16-v6si3639978pgd.12.2018.06.21.02.49.22;
        Thu, 21 Jun 2018 02:49:37 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932831AbeFUJsm (ORCPT <rfc822;rajatbajpailinux@gmail.com>
        + 99 others); Thu, 21 Jun 2018 05:48:42 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:12186 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932677AbeFUJsk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 21 Jun 2018 05:48:40 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b2b74600001>; Thu, 21 Jun 2018 02:48:17 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 21 Jun 2018 02:48:40 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 21 Jun 2018 02:48:40 -0700
Received: from [10.26.11.123] (172.20.13.39) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 21 Jun
 2018 09:48:36 +0000
Subject: Re: [PATCH v2 7/8] arm64: tegra: Add nodes for tcu on Tegra194
To:     Mikko Perttunen <mperttunen@nvidia.com>, <robh+dt@kernel.org>,
        <mark.rutland@arm.com>, <jassisinghbrar@gmail.com>,
        <gregkh@linuxfoundation.org>, <thierry.reding@gmail.com>
CC:     <devicetree@vger.kernel.org>, <linux-serial@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20180620122042.10950-1-mperttunen@nvidia.com>
 <20180620122042.10950-8-mperttunen@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <eb514b19-001b-0783-def5-101a03ab5a6c@nvidia.com>
Date:   Thu, 21 Jun 2018 10:48:33 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180620122042.10950-8-mperttunen@nvidia.com>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL106.nvidia.com (172.18.146.12) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 20/06/18 13:20, Mikko Perttunen wrote:
> Add nodes required for communication through the Tegra Combined UART.
> This includes the AON HSP instance, addition of shared interrupts
> for the TOP0 HSP instance, and finally the TCU node itself. Also
> mark the HSP instances as compatible to tegra194-hsp, as the hardware
> is not identical but is compatible to tegra186-hsp.
> 
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra194.dtsi | 34 +++++++++++++++++++++++++++++---
>  1 file changed, 31 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> index 6d699815a84f..d7f780b06fe2 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> @@ -217,10 +217,31 @@
>  		};
>  
>  		hsp_top0: hsp@3c00000 {
> -			compatible = "nvidia,tegra186-hsp";
> +			compatible = "nvidia,tegra194-hsp", "nvidia,tegra186-hsp";
>  			reg = <0x03c00000 0xa0000>;
> -			interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
> -			interrupt-names = "doorbell";
> +			interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>,
> +			             <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
> +			             <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
> +			             <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
> +			             <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
> +			             <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
> +			             <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>,
> +			             <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
> +			             <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "doorbell", "shared0", "shared1", "shared2",
> +			                  "shared3", "shared4", "shared5", "shared6",
> +			                  "shared7";
> +			#mbox-cells = <2>;
> +		};
> +
> +		hsp_aon: hsp@c150000 {
> +			compatible = "nvidia,tegra194-hsp", "nvidia,tegra186-hsp";
> +			reg = <0x0c150000 0xa0000>;
> +			interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>,
> +			             <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>,
> +			             <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>,
> +			             <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "shared0", "shared1", "shared2", "shared3";
>  			#mbox-cells = <2>;
>  		};
>  
> @@ -382,6 +403,13 @@
>  		};
>  	};
>  
> +	tcu: tcu {
> +		compatible = "nvidia,tegra194-tcu";
> +		mboxes = <&hsp_top0 TEGRA_HSP_MBOX_TYPE_SM 0>,
> +		         <&hsp_aon TEGRA_HSP_MBOX_TYPE_SM 1>;
> +		mbox-names = "rx", "tx";
> +	};
> +
>  	timer {
>  		compatible = "arm,armv8-timer";
>  		interrupts = <GIC_PPI 13
> 

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic