Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1837485imm; Thu, 21 Jun 2018 03:16:38 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIkYMxBMe3lPg2SxpDI+lBftMl61bH6psKyS+R5LnnvxFjXXPlSzdgHYGHn3Bqtyrx2vG0F X-Received: by 2002:a63:6e82:: with SMTP id j124-v6mr22241749pgc.349.1529576198809; Thu, 21 Jun 2018 03:16:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529576198; cv=none; d=google.com; s=arc-20160816; b=bRPCqqUTbU4VKlwQSeip35Gz0Q239Ljs8DI+wF+CHczZIRVf9yuWr1/I9esL1v4bTy vV9/qWDQpetubm+60OpOl4WJQ7hz4QlsLSpK5/is407NALzaSjUlm5rDibXfMoRSw3td JMCpx7RW8HfQc+jaV1NEI26JLg5Lob4tf3Temb4w4eEjDvGJAT34oOz62w5nUGBAZYxu aDuDnlqC4dy4al4Lv1iGCAKhdRy9Ipg3MLpHXOd1qe08oN67toE7PzxbLEyGCfvByrW+ MDJtxQSvsr5eIBSreH5hZRSvfVjQjDVhj+i7gAp7/Lf/pzOv1TuPpk9pHFyrEXVws1R4 wr7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=ZV7U3vX3mma9w5k/AjD0Rb7vfvYuoQ6ksRzBGaMjPs0=; b=lnA2PEp6EviaVMD3WcmzYBM2cG+Ih8wRft7Z3enU7NFnbhl5OqY2HcS/Yz+FuNyu4A Opoa4l8/6ZeF59b8jUi1DALwsu8TOhKDogV4D6zQZAV9M/vUkWPYnr31tSsCn7r/21C1 tdnAINDV3dy0JaPyjn7F3XPGoDQPXdiq4WrtLEJhMRxubQuQvujYg4NZsGboTDC8lOjT cte3co0jjVwUYgU4jiB+9el5yuYqzdon2iJML/RqGE24kSDpWEqs35DNehO2iezE+DFl uu1iDDwJvJdmVcMsKzEJY0wboUZ59NbfWBRzMx2GzAiudHAJu4FVR49a/3blMyVt5Znb VbXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l68-v6si3651700pgl.84.2018.06.21.03.16.24; Thu, 21 Jun 2018 03:16:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754226AbeFUKPT (ORCPT + 99 others); Thu, 21 Jun 2018 06:15:19 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:37096 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752799AbeFUKPR (ORCPT ); Thu, 21 Jun 2018 06:15:17 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1fVwcR-00081g-1W; Thu, 21 Jun 2018 18:15:11 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1fVwcM-00024c-S0; Thu, 21 Jun 2018 18:15:06 +0800 Date: Thu, 21 Jun 2018 18:15:06 +0800 From: Herbert Xu To: Stanimir Varbanov Cc: Vinod Koul , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Mackall , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, Vinod Koul Subject: Re: [PATCH 3/3] hwrng: msm - Add support for prng v2 Message-ID: <20180621101506.rnklbtapvfdev4xb@gondor.apana.org.au> References: <20180618141259.23141-1-vkoul@kernel.org> <20180618141259.23141-4-vkoul@kernel.org> <20180619142853.wgi5easw4zv6ttrb@gondor.apana.org.au> <966e9cd4-70a3-8d54-df0f-16df3df45fb5@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <966e9cd4-70a3-8d54-df0f-16df3df45fb5@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 21, 2018 at 12:56:34PM +0300, Stanimir Varbanov wrote: > > > Is this really a pseudo-RNG? If so it needs to be moved over to > > the algif_rng interface. > > Despite the register name (PRNG_ registers prefix) the IP is using FIPS > approved algorithm and we can claim that this is true hardware entropy > generator. Whether your RNG is a PRNG or not has nothing to do with the algorithm you use. No algorithm can generate entropy out of thin air. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt