Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] drm/bridge/sii8620: fix display of packed pixel modes
 in MHL2
To:     Maciej Purski <m.purski@samsung.com>,
        dri-devel@lists.freedesktop.org
Cc:     Archit Taneja <architt@codeaurora.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        David Airlie <airlied@linux.ie>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        linux-kernel@vger.kernel.org
From:   Andrzej Hajda <a.hajda@samsung.com>
Date:   Thu, 21 Jun 2018 12:53:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
        Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <1516706239-9104-1-git-send-email-m.purski@samsung.com>
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Message-Id: <20180621105329eucas1p2b6eeacae41ec8a3468c5126214dde228~6J3WB-Iyl0596805968eucas1p2C@eucas1p2.samsung.com>
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20180123111735eucas1p167f4aef33d1aea781a892f5245ac1567@eucas1p1.samsung.com>
        <1516706239-9104-1-git-send-email-m.purski@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 23.01.2018 12:17, Maciej Purski wrote:
> Currently packed pixel modes in MHL2 can't be displayed. The device
> automatically recognizes output format, so setting format other than
> RGB causes failure. Fix it by writing proper values to registers.
>
> Tested on MHL1 and MHL2 using various vendors' dongles both in
> DVI and HDMI mode.
>
> Signed-off-by: Maciej Purski <m.purski@samsung.com>

Another missed one, queued to drm-misc-fixes.

--
Regards
Andrzej

> ---
>  drivers/gpu/drm/bridge/sil-sii8620.c | 17 +----------------
>  1 file changed, 1 insertion(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c
> index 1718c2e..e13708d 100644
> --- a/drivers/gpu/drm/bridge/sil-sii8620.c
> +++ b/drivers/gpu/drm/bridge/sil-sii8620.c
> @@ -1005,20 +1005,11 @@ static void sii8620_stop_video(struct sii8620 *ctx)
>  
>  static void sii8620_set_format(struct sii8620 *ctx)
>  {
> -	u8 out_fmt;
> -
>  	if (sii8620_is_mhl3(ctx)) {
>  		sii8620_setbits(ctx, REG_M3_P0CTRL,
>  				BIT_M3_P0CTRL_MHL3_P0_PIXEL_MODE_PACKED,
>  				ctx->use_packed_pixel ? ~0 : 0);
>  	} else {
> -		if (ctx->use_packed_pixel)
> -			sii8620_write_seq_static(ctx,
> -				REG_VID_MODE, BIT_VID_MODE_M1080P,
> -				REG_MHL_TOP_CTL, BIT_MHL_TOP_CTL_MHL_PP_SEL | 1,
> -				REG_MHLTX_CTL6, 0x60
> -			);
> -		else
>  			sii8620_write_seq_static(ctx,
>  				REG_VID_MODE, 0,
>  				REG_MHL_TOP_CTL, 1,
> @@ -1026,15 +1017,9 @@ static void sii8620_set_format(struct sii8620 *ctx)
>  			);
>  	}
>  
> -	if (ctx->use_packed_pixel)
> -		out_fmt = VAL_TPI_FORMAT(YCBCR422, FULL) |
> -			BIT_TPI_OUTPUT_CSCMODE709;
> -	else
> -		out_fmt = VAL_TPI_FORMAT(RGB, FULL);
> -
>  	sii8620_write_seq(ctx,
>  		REG_TPI_INPUT, VAL_TPI_FORMAT(RGB, FULL),
> -		REG_TPI_OUTPUT, out_fmt,
> +		REG_TPI_OUTPUT, VAL_TPI_FORMAT(RGB, FULL),
>  	);
>  }
>