Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1958699imm; Thu, 21 Jun 2018 05:10:28 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJQ/xcsuGB/eO2kfegzH8M6mkx1S4xj/nXdN6WAYvU4hnQ4kTdtNtQmWf+bI4v+Qankj1Qb X-Received: by 2002:a17:902:543:: with SMTP id 61-v6mr28348048plf.47.1529583028470; Thu, 21 Jun 2018 05:10:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529583028; cv=none; d=google.com; s=arc-20160816; b=OyEgyQgkXPyDh4grq8/gKntz92yTMb/wmgqgemSYH7jJtXfAEVvAJbMTsADzQg13nj cJpN/+/kq50ue9KF5QN9ymJ+1JJomga9sFfjbrOk7jL8BEpQQdF+XoK90id1XDLqQ+Lq yKd5d3x4Ttnj1TQOetyTv/kRZI5FdI70Bq6lbK+Zgb1QYs+j2QXaSI9rYu+XCeKQv0r8 KgsCJaf4YrJxI3XM70R41VIdkDpFzU77fa/FueJT6uuofHHXgx5O8q9CE0KDF+oypma9 xVkkTjkSQSziSdryQxnPImNVljPV9wzIYSP3gVgIZMnWe2OgNxFV0QCCYidh+UOcuGfO /80Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=vCeF7Hzvk3znfrqrAJx9RTteANe5pJm9wOiDW0oriBA=; b=ULPol7NIS9Y1VDBmKg0Dxsc9pGTDMlrVzmF00u6LDqOYbUU8wTxaQLxKnXHvWrUAsw Jf2uftGMyJ9rdvF54KODFCSBx2wXWLZf1LnR0rd+grlhLmXGUY6n1+WkLLaPNFybQ/k/ uirrZjhdeyX4AgIfANUiVIA0Du5LxqFGmmeM6L9LZch00R+wA5/UUFVAjs6sNiEpbCHi ZA66tVSBj+1iYcryd+pA5ulCJgNbzhg7RfmwhFX0cY8z4/E/31oQm9absrG3YOnhgNZL Fb0jLEGEmTDpR2fTpLAfiW4EtmqsTnU+e0/YthDcekp6qlGFpVixyEO0QfshZEJ4bJMX +KvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f26-v6si4226769pfn.366.2018.06.21.05.10.13; Thu, 21 Jun 2018 05:10:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933370AbeFUMJS (ORCPT + 99 others); Thu, 21 Jun 2018 08:09:18 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:58336 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933199AbeFUMJP (ORCPT ); Thu, 21 Jun 2018 08:09:15 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EAEEB8182D16; Thu, 21 Jun 2018 12:09:14 +0000 (UTC) Received: from plouf.banquise.eu.com (ovpn-117-99.ams2.redhat.com [10.36.117.99]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F3682026D6B; Thu, 21 Jun 2018 12:09:13 +0000 (UTC) From: Benjamin Tissoires To: Jiri Kosina , Dmitry Torokhov Cc: Mario.Limonciello@dell.com, Peter Hutterer , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires Subject: [PATCH v3 01/12] input: add MT_TOOL_DIAL Date: Thu, 21 Jun 2018 14:08:57 +0200 Message-Id: <20180621120908.16706-2-benjamin.tissoires@redhat.com> In-Reply-To: <20180621120908.16706-1-benjamin.tissoires@redhat.com> References: <20180621120908.16706-1-benjamin.tissoires@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 21 Jun 2018 12:09:15 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 21 Jun 2018 12:09:15 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'benjamin.tissoires@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A dial is a tool you place on a multitouch surface which reports its orientation or a relative angle of rotation when rotating its knob. Some examples are the Dell Totem (on the Canvas 27"), the Microsoft Dial, or the Griffin Powermate, though the later can't be put on a touch surface. We give some extra space to account for other types of fingers if we need (MT_TOOL_THUMB) Slightly change the documentation to not make it mandatory to update each MT_TOOL we add. Acked-by: Dmitry Torokhov Signed-off-by: Benjamin Tissoires --- new in v2 (extracted from previous series in its own patch) changes in v3: - re-insert the change in include/uapi/linux/input.h --- Documentation/input/multi-touch-protocol.rst | 12 ++++++------ include/uapi/linux/input.h | 3 ++- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/Documentation/input/multi-touch-protocol.rst b/Documentation/input/multi-touch-protocol.rst index b51751a0cd5d..6be70342e709 100644 --- a/Documentation/input/multi-touch-protocol.rst +++ b/Documentation/input/multi-touch-protocol.rst @@ -310,12 +310,12 @@ ABS_MT_TOOL_Y ABS_MT_TOOL_TYPE The type of approaching tool. A lot of kernel drivers cannot distinguish between different tool types, such as a finger or a pen. In such cases, the - event should be omitted. The protocol currently supports MT_TOOL_FINGER, - MT_TOOL_PEN, and MT_TOOL_PALM [#f2]_. For type B devices, this event is - handled by input core; drivers should instead use - input_mt_report_slot_state(). A contact's ABS_MT_TOOL_TYPE may change over - time while still touching the device, because the firmware may not be able - to determine which tool is being used when it first appears. + event should be omitted. The protocol currently mainly supports + MT_TOOL_FINGER, MT_TOOL_PEN, and MT_TOOL_PALM [#f2]_. + For type B devices, this event is handled by input core; drivers should + instead use input_mt_report_slot_state(). A contact's ABS_MT_TOOL_TYPE may + change over time while still touching the device, because the firmware may + not be able to determine which tool is being used when it first appears. ABS_MT_BLOB_ID The BLOB_ID groups several packets together into one arbitrarily shaped diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index 7288a7c573cc..e931b0468b6d 100644 --- a/include/uapi/linux/input.h +++ b/include/uapi/linux/input.h @@ -273,7 +273,8 @@ struct input_mask { #define MT_TOOL_FINGER 0 #define MT_TOOL_PEN 1 #define MT_TOOL_PALM 2 -#define MT_TOOL_MAX 2 +#define MT_TOOL_DIAL 10 +#define MT_TOOL_MAX 10 /* * Values describing the status of a force-feedback effect -- 2.14.3