Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1992907imm; Thu, 21 Jun 2018 05:41:52 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKWce9pFVLDb67mpwbnB+HnBV9tUJ9dg6PYriOpvshMRHW7xXYj5HokCpFvSOO8yxfhoKuu X-Received: by 2002:a17:902:e187:: with SMTP id cd7-v6mr28725783plb.166.1529584912514; Thu, 21 Jun 2018 05:41:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529584912; cv=none; d=google.com; s=arc-20160816; b=B4SqFzqzttRI2gvh92KvQUFAfqjlc7Ms71WLCXt1zirseqfjmyvoIShqxZ+d4fOg2O +IRc32QrwmCljSq2+hyf1UUVCfhANGC9T4zIy74R8ANjy/dNS1rwKhIeeSkJLAVnH6xi hXpcM48gUhKXyOVmp8jDKYa/L9y96/P4TyuaxWQ/jcvU1cV0daTD/lhnErVoyYHbCerK J3yFd8A4i18titOtcyLuKOSDValJJSyLbjvvSUFlT8bi4PZpL6IZntCpDaCF3z5TJOtk wHfIk7aW4Hw+1p2m/zJPiriiavlT1+s5vPkRyVysAigf1EsPALF58wEISyatJf4sNo/0 F+Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=1YRazIREcG4Ml6wgN4NMgRm9G/jpc/Dr7vnEj4TbW4w=; b=gtzyv2N0/apayVQ0rQ4bx7PZrR0S1i7DOQVabbW2jxBA7VdFLzSmGRDkA2tP2kupv8 Hw5Nbttv7EFYMBo6reSKzG0GADl+UmBWnYl9GiUI6/iOq8EDQnDtpC/HG9/S0yCVm97V vEYuYJ2tDi+iqN5ygMhv8fpsLjD8FnsMlsIMBPvsS1DhgVFEm3j7Soi3jZeLGrc001hz 7WmmpMwWDIbiJoXV5FXUPtyvqrwyQ3JIpCCslwfKkJkQaFb0/AWhNP9a8b+8iHWRZPSy 51YKXNObk/Anlw2uN24b1sAGBT78JCcqzLZSrTXlE4zfRJGFQXe/ESBobz5sRuVd12/m azmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=jn2+RErE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1-v6si4847704plj.386.2018.06.21.05.41.38; Thu, 21 Jun 2018 05:41:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=jn2+RErE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933292AbeFUMko (ORCPT + 99 others); Thu, 21 Jun 2018 08:40:44 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:54758 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932764AbeFUMkn (ORCPT ); Thu, 21 Jun 2018 08:40:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1YRazIREcG4Ml6wgN4NMgRm9G/jpc/Dr7vnEj4TbW4w=; b=jn2+RErE3vDCn8AKXk1z2wkhR VmWbxzHmT3JfOTc5iUaYcISevyARF8nLl1S4QHcMUIw66vQdMk9VOZUFiCYB1as1kr0WiwpfkwNRH dVFY0uaWXSCsOxaXhRwxYnVyihUHwnnK/HCjKlzw8EoKtpeCXKCvBAU9YQlSDDFj0vf5siJCcNDsT UKyyXFhwZTsapaFNvT+nXcnnOL/M2FPO77ChGY6f7jPvr3idAc8xXMHVKhYOl/1DD0USZfcH2Z6YO FRWFiMi1k28Z2jsqKXq/0MqtQLaz28fFAlCXcLTPsnwoxKHNtHCFSmP+UGmVEWtVyFwuu+bq21nEU EdBnLzOKQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fVytA-00036b-VZ; Thu, 21 Jun 2018 12:40:36 +0000 Date: Thu, 21 Jun 2018 05:40:36 -0700 From: Christoph Hellwig To: Jann Horn Cc: Jens Axboe , FUJITA Tomonori , Doug Gilbert , "James E.J. Bottomley" , "Martin K. Petersen" , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro , kernel-hardening@lists.openwall.com, security@kernel.org Subject: Re: [PATCH] sg, bsg: mitigate read/write abuse, block uaccess in release Message-ID: <20180621124036.GA6348@infradead.org> References: <20180615152335.208202-1-jannh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180615152335.208202-1-jannh@google.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Can you resend a patch for the sg driver alone? Also I think we just want the scsi_safe_file_access code inside sg itself, it really has nothing to do with the reset of the contents in scsi_cmnd.h