Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp2006522imm; Thu, 21 Jun 2018 05:55:14 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIb9bMqPAGO48oCzo/TpjOz47qWMCEY+26bbc3fZRN2Dm9kZ6UJ6Dtaag0ClBFqKjkR9Kic X-Received: by 2002:a62:d653:: with SMTP id r80-v6mr27323977pfg.54.1529585714513; Thu, 21 Jun 2018 05:55:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529585714; cv=none; d=google.com; s=arc-20160816; b=TtxP+PSRosrXnnjj+cdg/RnfQOj//EfPfIqFb5vYyJfZZ0es+C8e2k0E6RK9ZjqbmH 2fUheQ+hcvHqOyMoiHz88KilocLmaDJk23m1rt6ACD/FSC7xjn7/WzvKuK5Crtc0W9sd C7l6AOcKUC5Lki3vm/aZS0Wgh0sVWMoo4tuacTXsFH73cv1C/gtZdV8QHVa1HMGUMxH0 EMlgi0Je7Yl/eSCJRzmWGfL0dMrKwGuii6aZNgCKSfu6Re7A2niD5KbnEAbX/radXqWd kupgNC6nG7RZgkkeYIVL4HTy5gigK5/td8Ou0xAhal2CDOERM4qwKqafJqRCUaTqkFHH XIhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=V3s8PJErPJoIfVQxeCVaRE/NqRMx/ttza8o/WjOwjlA=; b=Owrs0yv2mj4UhnfrumZ6XCHJ1vEF9Hv9o4AMgF+r4TuLYlCzNzqpHI+fYxpM7S5kit OE4Dd1WtLM/1yEDcIhBB1jO9jrbIM16YNXzW5FIAwPMII+Ybn/4ODCgE+sar2lJ+QAn/ YUMMoEDanBXR9w5x72nFE6XNUOVd93lzAj4Lk3sGn43jLHhEOSirOxFLiVFQHS/zhnYB l5Ihtj1hNjkYOoDwOOVxHixFfJldYAbgv5jxrY0RfTjo0lbYaFJ/wLoQjZ1DwWQEcfhy fxuFMAA8UFkEjoi6c+KUGoH4z6cQULDNfsN8vkQR3P2sAcyyLKZpDmaanx01HubnJTNM YF7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=GvCFmBLI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e5-v6si3793042pgp.105.2018.06.21.05.54.59; Thu, 21 Jun 2018 05:55:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=GvCFmBLI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933196AbeFUMyV (ORCPT + 99 others); Thu, 21 Jun 2018 08:54:21 -0400 Received: from mail-ot0-f195.google.com ([74.125.82.195]:33592 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932850AbeFUMyR (ORCPT ); Thu, 21 Jun 2018 08:54:17 -0400 Received: by mail-ot0-f195.google.com with SMTP id h6-v6so3448994otj.0 for ; Thu, 21 Jun 2018 05:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V3s8PJErPJoIfVQxeCVaRE/NqRMx/ttza8o/WjOwjlA=; b=GvCFmBLIrGHh62EQz7ehG8Su+RqtzO2C2h4v3nu86841WQsn8mB2zpnl2o7rOzmeDo +5sk+cFsE9eab/fqfyUNtXWCEDX3gGIuYumOOOR7umiI0ZouH3Z12ACx4tQgVETXDxaX hIAH7T37otqELM5T4J/rz65wNBXcEWlMzwmh6PxMoocA1LNQb875+GveGKpnEhgf5uyQ dMuaXeYCVmoSl6DTzFFAY6F5y4L3rcs0p7ZmfEz/5trfO0ZktsZhHP+9EpeMdB3B+yDZ KwIzM/slShRoBNel87kqYsBdluQ3P/UQlDQ5WCTvEUEwWwtWVnirXhlC5GwPaw5wUA21 I9ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V3s8PJErPJoIfVQxeCVaRE/NqRMx/ttza8o/WjOwjlA=; b=R7AA7Qj9BMlxY6dUZMRJVuFxW8CWDS4pn4J1NaH7br77W/aki+PvnfXw7db0NveNuQ oHvrSVroJEZUT1/GpZ7PYrrIi/ZgWzezPnp8mdAtKuHDAlv1pcMuDPVx/4GJGSL3BN2I CyMd2VtlhwnOM2u52LSHCN+SukcTZllHjaW3gZgMu4ip49dtjo9y6PsswBsG7i7add5K t1du7u5n5kfTXDy6nk4e/i4lKvhJKXUKMoBomx6vW2R02A+NOTXOkVGQ+YKhQJSRe8JH 1clyY5KTZjr9l0hXPAdVxAcjmRTYG3zuV6DcRD/alS+ilc6tszjEL/ZpSqSyjXnIsWzH Dlsg== X-Gm-Message-State: APt69E06kv/lCM+Jcl5LK+z6Kt6fU8OuQi3JGHToNiNkO+nnO8wBruO+ GleMJG26sJFgWmajJAa8y4lNZ50mu94jX7t3oO8K4A== X-Received: by 2002:a9d:2115:: with SMTP id i21-v6mr14851928otb.72.1529585656787; Thu, 21 Jun 2018 05:54:16 -0700 (PDT) MIME-Version: 1.0 References: <20180615152335.208202-1-jannh@google.com> <20180621124036.GA6348@infradead.org> In-Reply-To: <20180621124036.GA6348@infradead.org> From: Jann Horn Date: Thu, 21 Jun 2018 14:54:05 +0200 Message-ID: Subject: Re: [PATCH] sg, bsg: mitigate read/write abuse, block uaccess in release To: Christoph Hellwig Cc: axboe@kernel.dk, fujita.tomonori@lab.ntt.co.jp, dgilbert@interlog.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, kernel list , Al Viro , Kernel Hardening , security@kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 21, 2018 at 2:40 PM Christoph Hellwig wrote: > Can you resend a patch for the sg driver alone? Okay, will do. > Also I think > we just want the scsi_safe_file_access code inside sg itself, > it really has nothing to do with the reset of the contents in > scsi_cmnd.h Okay. (I put it there because I couldn't figure out a better common header and didn't want to create two new copies of the code.)