Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp2007748imm; Thu, 21 Jun 2018 05:56:24 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLzgHxY2R0G3Id6HOEgbOPTlIBQNsU3qYGEQ+KTMSHOq0GKS78vQEQ6Wl/AHoEYqemf7bjc X-Received: by 2002:a63:5401:: with SMTP id i1-v6mr21990434pgb.187.1529585784829; Thu, 21 Jun 2018 05:56:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529585784; cv=none; d=google.com; s=arc-20160816; b=oMZHB0Iu16mzeyqyLjoMeUEHPF9bB9sxZiJBiUOngZxUqGg3V3hiX0/JRryKvylzOW GFTGiTFemoYGBpUINC6nPr3HdFFuxowlWn+cVnKCI5Z1CsCMWHYilSrBRoERezp8tvng gHbCjh8x79wDQfhuEdmGI6xGa8rG4sdHxT3r9zSyM0lFuk5XZdAjJkC6jCw5KIl1YL9K WjATgt9apFknmyxApiYlcxp18E3pnp/csX9hNHVi30P/IzYFhdVUvr2BxC/4GzkJeNYT 0s2duwPJH6Y+MkmZjAwXr+jqki11I0dC5KJNaklzmvDwDYvIMVFIaaTHzMaHFkV+qQZS uumg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=VZYAUtzqbbG6bOaYWVMYMXjT/A3o+0zkhxP0BWhB238=; b=HH4Mz9lZp8A6E6fFhexxqilGy2NWfeTiXfo/FTpHy1xZqRIvcFuuZwJKRvPUk/05j2 KixlnDBz+Q6AhIeoeZb042nt2U17GMrqFVSQg9u1t2VQ3FYV3KDaFj20kO3hQQfSvzRz QJbrIrxVZ4XjsBeAmrS4FgzRxcZSsBhiggluCCkcSHhD9ivoa/meM34inwHpSmwJfEw6 SsoAEg8tC8BPgcx+gngde8xP/coeCE3IpK7odbDvDyJGLt1iVEasulxYYMJewZd1H5au PvGh7+C6B4++Q+dJTs4UPE410/LPywBTHsCWoqeep/OaMQFWqYSsLnEqLreVJR+vbcy5 DtXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=t2BSDepM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bc12-v6si4680819plb.373.2018.06.21.05.56.11; Thu, 21 Jun 2018 05:56:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=t2BSDepM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933382AbeFUMzV (ORCPT + 99 others); Thu, 21 Jun 2018 08:55:21 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:40814 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932850AbeFUMzR (ORCPT ); Thu, 21 Jun 2018 08:55:17 -0400 Received: by mail-wr0-f195.google.com with SMTP id g18-v6so3090318wro.7; Thu, 21 Jun 2018 05:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VZYAUtzqbbG6bOaYWVMYMXjT/A3o+0zkhxP0BWhB238=; b=t2BSDepM8dV9kD242zYg/ib0uEA3k4vTmLc2kW2cvBaPnWY1y/G4FSoVccveP4t+f7 CfSY2ydd5wpHhDa4V02Lfo05HogMWJlhG1rcuZ3XCnY7TDoepvo216iUxpYPRZOvGih6 7j2qow8SWqbJMO+Eu0Tndpiy7bN8YqThkxRXRCnxP1+4+r67ZNQACd4W9ICPiNiqgSLJ Aha0m51IDLQSvQ0gbbQCUVBs6BgPVAEI14N3AonmI7+FDLwFGXvqA3N++MtFLgLDYZbO Hw+bWRFPelxrKnp8lnnDRolAtPjtwLVP/A7K3OmhfYTVgaghDdg0jiwbvbMZ4R8z4VJi a0vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=VZYAUtzqbbG6bOaYWVMYMXjT/A3o+0zkhxP0BWhB238=; b=KLaQ5JE7un8wclbzoc143H/S81M0IgXIRu7mKByJXqjk3dMS02KNbcRbP4C3o/s81L cVldUy+YQHMjRYGAQ8jvVR1pO3juIgsjVsdvxmBVttpGGKhC8T1z+N89SplvOZ0uy5DI EFqgUftTzlw7PtvCEQZRQFnOmXFkS8qVmb3sHbe+Nw3WEpbJWE6akeesdahjbPeT0z+C afqfqqYuRpwW4r/ww9pvP71QRpViDlAiESiqZ3MZY9rdpsXT7HMw/8BTmF/KpZ+rzSs0 Blbp53rHrEBKf48gSqKR0oXfWYs0UfuNEvGo0XVkWCZzaFd/Cl2JuwPoNd3ibahJQzUW urmw== X-Gm-Message-State: APt69E0TAhZE6BaO1fPn51GPFgZHEBHdnrH5pkCk4+FyWCOCTyM7ZMOc VBL21Q9566/Q5/iHJwMDh8E= X-Received: by 2002:adf:88ca:: with SMTP id g10-v6mr19992056wrg.62.1529585715514; Thu, 21 Jun 2018 05:55:15 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id v15-v6sm2193926wrq.37.2018.06.21.05.55.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Jun 2018 05:55:14 -0700 (PDT) Date: Thu, 21 Jun 2018 14:55:11 +0200 From: Ingo Molnar To: Jarkko Sakkinen Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, dave.hansen@intel.com, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, Alexei Starovoitov , Andi Kleen , Andrew Morton , Andy Lutomirski , Borislav Petkov , "David S. Miller" , David Woodhouse , Greg Kroah-Hartman , "H. Peter Anvin" , "open list:INTEL SGX" , Janakarajan Natarajan , "Kirill A. Shutemov" , Konrad Rzeszutek Wilk , "open list:KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86)" , Len Brown , Linus Walleij , "open list:CRYPTO API" , "open list:DOCUMENTATION" , open list , "open list:SPARSE CHECKER" , Mauro Carvalho Chehab , Peter Zijlstra , "Rafael J. Wysocki" , Randy Dunlap , Ricardo Neri , Thomas Gleixner , Tom Lendacky , Vikas Shivappa Subject: Re: [PATCH v11 00/13] Intel SGX1 support Message-ID: <20180621125511.GA4287@gmail.com> References: <20180608171216.26521-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180608171216.26521-1-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jarkko Sakkinen wrote: > create mode 100644 drivers/platform/x86/intel_sgx/Kconfig > create mode 100644 drivers/platform/x86/intel_sgx/Makefile > create mode 100644 drivers/platform/x86/intel_sgx/le/Makefile > create mode 100644 drivers/platform/x86/intel_sgx/le/enclave/Makefile > create mode 120000 drivers/platform/x86/intel_sgx/le/enclave/aesni-intel_asm.S > create mode 100644 drivers/platform/x86/intel_sgx/le/enclave/cmac_mode.c > create mode 100644 drivers/platform/x86/intel_sgx/le/enclave/cmac_mode.h > create mode 100644 drivers/platform/x86/intel_sgx/le/enclave/encl_bootstrap.S > create mode 100644 drivers/platform/x86/intel_sgx/le/enclave/main.c > create mode 100644 drivers/platform/x86/intel_sgx/le/enclave/main.h > create mode 100644 drivers/platform/x86/intel_sgx/le/enclave/sgx_le.lds > create mode 100644 drivers/platform/x86/intel_sgx/le/enclave/sgxsign.c > create mode 120000 drivers/platform/x86/intel_sgx/le/enclave/string.c > create mode 100644 drivers/platform/x86/intel_sgx/le/entry.S > create mode 100644 drivers/platform/x86/intel_sgx/le/include/sgx_asm.h > create mode 100644 drivers/platform/x86/intel_sgx/le/main.c > create mode 100644 drivers/platform/x86/intel_sgx/le/main.h > create mode 100644 drivers/platform/x86/intel_sgx/le/sgx_le_piggy.S > create mode 100644 drivers/platform/x86/intel_sgx/le/string.c > create mode 100644 drivers/platform/x86/intel_sgx/sgx.h > create mode 100644 drivers/platform/x86/intel_sgx/sgx_encl.c > create mode 100644 drivers/platform/x86/intel_sgx/sgx_encl_page.c > create mode 100644 drivers/platform/x86/intel_sgx/sgx_fault.c > create mode 100644 drivers/platform/x86/intel_sgx/sgx_ioctl.c > create mode 100644 drivers/platform/x86/intel_sgx/sgx_le.c > create mode 100644 drivers/platform/x86/intel_sgx/sgx_le_proxy_piggy.S > create mode 100644 drivers/platform/x86/intel_sgx/sgx_main.c > create mode 100644 drivers/platform/x86/intel_sgx/sgx_vma.c Just some quick feedback: these are core kernel functionality and should be in arch/x86/, not in drivers/platform/. Thanks, Ingo