Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp2031394imm; Thu, 21 Jun 2018 06:14:54 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIz07EAIyJWQFYZgJ69ZXFoEEhAovcvAMmXnJkq9hTNVcTQVW3JiKLUCjSbc5/wZyf3Sp0r X-Received: by 2002:a17:902:850b:: with SMTP id bj11-v6mr3224203plb.210.1529586894079; Thu, 21 Jun 2018 06:14:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529586894; cv=none; d=google.com; s=arc-20160816; b=xcuEgSGg9w4SZH4GMT8X0fML/tMSnFVl+tRUQrPBcVDVZ1XmsKg65g+HRSr4GQXMii mhw3yZDLPQXUY10uBlxI6TogHSUEF+rPj/1SoamrI6dUj6rgyx9ehVp0rDflXF9c1meZ kbWtBLT2fuYod11h02eknq6rcRgi3BTKJpISiiVDqGYEMR4lnPV054hX9/cIDBfn4uEj d+xruaLobPaO1Kr9vZrRkDUft7P8rBUwKu2R0y14WPh4L60y+Ep58KC35acFLZ/SxSge XPtWDKgki3uyuN1NcxJPD6Sviwe3rY28oK0sxMwXHlZsIbM6YqKZc36kIQrtJIJkH500 CEow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :arc-authentication-results; bh=UpS9fcu4ZJdl1YRocgOYTIKeNukEGdnIA0PhZBfPk20=; b=dj0VD8H8tjYrb8vryQcPsa/GrLQAh+hxBHvPIHiLMLghWWMY59CLh06/AhJTKVY8wG tJHPsBn37a7Bsn8AUhYsK4Tgth6Dq68nnbD04UZmgCMKA1GoQr1A62fbvZutNSFf+Oml YDw3/A2fbCEjWEXNfQZnsXMI5uEnaXsQC0HHqWcdezkG7/uDHfEHGfteTCtSOlSaV6+N fn94Wg/KPx4ghD2L/7c26I1hLfjKL3y0kyX1tx1hx4zAI6ZiNzj5J3HuRLR/j5+eE3zd 6pgvS6CFmskgC3fe8jv3SlvPlJwiu7/JOlccgJ55CYm6cdvAoXPaIXSwRChqch5GiS6y 9fVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31-v6si4724079plk.49.2018.06.21.06.14.39; Thu, 21 Jun 2018 06:14:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932944AbeFUNMm (ORCPT + 99 others); Thu, 21 Jun 2018 09:12:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:47514 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932734AbeFUNMk (ORCPT ); Thu, 21 Jun 2018 09:12:40 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 660CCAC7D; Thu, 21 Jun 2018 13:12:38 +0000 (UTC) Subject: Re: [PATCH 2/2] xen-netfront: Update features after registering netdev To: Ross Lagerwall , netdev@vger.kernel.org Cc: Boris Ostrovsky , "David S. Miller" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Liam Shepherd References: <20180621130021.27029-1-ross.lagerwall@citrix.com> <20180621130021.27029-3-ross.lagerwall@citrix.com> From: Juergen Gross Openpgp: preference=signencrypt Autocrypt: addr=jgross@suse.com; prefer-encrypt=mutual; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNHkp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmRlPsLAeQQTAQIAIwUCU4xw6wIbAwcL CQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJELDendYovxMvi4UH/Ri+OXlObzqMANruTd4N zmVBAZgx1VW6jLc8JZjQuJPSsd/a+bNr3BZeLV6lu4Pf1Yl2Log129EX1KWYiFFvPbIiq5M5 kOXTO8Eas4CaScCvAZ9jCMQCgK3pFqYgirwTgfwnPtxFxO/F3ZcS8jovza5khkSKL9JGq8Nk czDTruQ/oy0WUHdUr9uwEfiD9yPFOGqp4S6cISuzBMvaAiC5YGdUGXuPZKXLpnGSjkZswUzY d9BVSitRL5ldsQCg6GhDoEAeIhUC4SQnT9SOWkoDOSFRXZ+7+WIBGLiWMd+yKDdRG5RyP/8f 3tgGiB6cyuYfPDRGsELGjUaTUq3H2xZgIPfOwE0EU4xwFgEIAMsx+gDjgzAY4H1hPVXgoLK8 B93sTQFN9oC6tsb46VpxyLPfJ3T1A6Z6MVkLoCejKTJ3K9MUsBZhxIJ0hIyvzwI6aYJsnOew cCiCN7FeKJ/oA1RSUemPGUcIJwQuZlTOiY0OcQ5PFkV5YxMUX1F/aTYXROXgTmSaw0aC1Jpo w7Ss1mg4SIP/tR88/d1+HwkJDVW1RSxC1PWzGizwRv8eauImGdpNnseneO2BNWRXTJumAWDD pYxpGSsGHXuZXTPZqOOZpsHtInFyi5KRHSFyk2Xigzvh3b9WqhbgHHHE4PUVw0I5sIQt8hJq 5nH5dPqz4ITtCL9zjiJsExHuHKN3NZsAEQEAAcLAXwQYAQIACQUCU4xwFgIbDAAKCRCw3p3W KL8TL0P4B/9YWver5uD/y/m0KScK2f3Z3mXJhME23vGBbMNlfwbr+meDMrJZ950CuWWnQ+d+ Ahe0w1X7e3wuLVODzjcReQ/v7b4JD3wwHxe+88tgB9byc0NXzlPJWBaWV01yB2/uefVKryAf AHYEd0gCRhx7eESgNBe3+YqWAQawunMlycsqKa09dBDL1PFRosF708ic9346GLHRc6Vj5SRA UTHnQqLetIOXZm3a2eQ1gpQK9MmruO86Vo93p39bS1mqnLLspVrL4rhoyhsOyh0Hd28QCzpJ wKeHTd0MAWAirmewHXWPco8p1Wg+V+5xfZzuQY0f4tQxvOpXpt4gQ1817GQ5/Ed/wsDtBBgB CAAgFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAlrd8NACGwIAgQkQsN6d1ii/Ey92IAQZFggA HRYhBFMtsHpB9jjzHji4HoBcYbtP2GO+BQJa3fDQAAoJEIBcYbtP2GO+TYsA/30H/0V6cr/W V+J/FCayg6uNtm3MJLo4rE+o4sdpjjsGAQCooqffpgA+luTT13YZNV62hAnCLKXH9n3+ZAgJ RtAyDWk1B/0SMDVs1wxufMkKC3Q/1D3BYIvBlrTVKdBYXPxngcRoqV2J77lscEvkLNUGsu/z W2pf7+P3mWWlrPMJdlbax00vevyBeqtqNKjHstHatgMZ2W0CFC4hJ3YEetuRBURYPiGzuJXU pAd7a7BdsqWC4o+GTm5tnGrCyD+4gfDSpkOT53S/GNO07YkPkm/8J4OBoFfgSaCnQ1izwgJQ jIpcG2fPCI2/hxf2oqXPYbKr1v4Z1wthmoyUgGN0LPTIm+B5vdY82wI5qe9uN6UOGyTH2B3p hRQUWqCwu2sqkI3LLbTdrnyDZaixT2T0f4tyF5Lfs+Ha8xVMhIyzNb1byDI5FKCb Message-ID: <754ddc45-215a-458c-2b58-e9d979471f4d@suse.com> Date: Thu, 21 Jun 2018 15:12:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180621130021.27029-3-ross.lagerwall@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/06/18 15:00, Ross Lagerwall wrote: > Update the features after calling register_netdev() otherwise the > device features are not set up correctly and it not possible to change > the MTU of the device. After this change, the features reported by > ethtool match the device's features before the commit which introduced > the issue and it is possible to change the device's MTU. > > Fixes: f599c64fdf7d ("xen-netfront: Fix race between device setup and open") > Reported-by: Liam Shepherd > Signed-off-by: Ross Lagerwall Reviewed-by: Juergen Gross Juergen