From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jens Axboe <axboe@suse.de>
Cc: Pavel Machek <pavel@ucw.cz>, Patrick Mochel <mochel@osdl.org>,
       Linus Torvalds <torvalds@osdl.org>,
       kernel list <linux-kernel@vger.kernel.org>
In-Reply-To: <20030902174126.GB14209@suse.de>
References: <20030823114738.B25729@flint.arm.linux.org.uk>
	 <Pine.LNX.4.44.0308250840360.1157-100000@cherise>
	 <20030825172737.E16790@flint.arm.linux.org.uk>
	 <20030901120208.GC1358@openzaurus.ucw.cz>  <20030902174126.GB14209@suse.de>
Message-Id: <1063138756.642.48.camel@gaston>
Mime-Version: 1.0
Date: Tue, 09 Sep 2003 22:19:17 +0200
Subject: Re: [PM] Patrick: which part of "maintainer" and "peer review"
	needs explaining to you?
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 862
Lines: 27


> ide-cd should have a flush write cache as well, for mtr, dvd-ram, cd-rw
> with packet writing, etc.

This is currently not done by the ide-cd suspend state machine, I did
the infrastructure and ide-disk implementation, but I'm leaving things
like ide-cd to you :)

Patrick: As we discussed on IRC, the actual PM state constants you
defined don't match the old "S" levels, thus this code in ide-disk
suspend notifier:

                if (rq->pm->pm_state == 4)
 
to avoid stopping the platter on  suspend-to-disk will not work.

Should I fix the above to use a PM_* constant or will you fix the
constants ?

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/