Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp2151066imm; Thu, 21 Jun 2018 07:59:35 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLLQzX9eg4noM2appxPMzKJx4Q249PsApVoZE+X4arLy1af2iShHlPWPsiWM5zCvbfiP3xx X-Received: by 2002:a17:902:5602:: with SMTP id h2-v6mr29193794pli.314.1529593175685; Thu, 21 Jun 2018 07:59:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529593175; cv=none; d=google.com; s=arc-20160816; b=o3iHzwchd/DYjFVbf5ZtVjgroXg27kF5t//vVrlKXQmnUgu4/0eDCdPw+QXiamtCCR uZZjBEpX1eef7Y/2CXStrs/uIJnAI5bGYeNadYyc8BT5bx8rpV/8610HghIS9XqI8fAh sDe/684ifEqRPrYm6UGm5vxvorJIFw8sBC4OttuzirAQVZQIfrAfM63uANGie39YwA9b lXu/Ak8EY0LMfrGu5VuKaiQ5f0guikpOonS2E2/XUvXI8N1fUxPl3FegTD+2VwjyFmUu ejNSYYNJiKyc3/7GhOGpDyxNhHaTtzunaxSJ7r19x782fMWE33dW5XKDvSIG7qO34t8G TYnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=JjJDpYrp1ZqrftXZ9az+npr+RsGHDvUIftSG0wiHdZU=; b=wIm1DVDBW514rfWbJQM9tcceGcXm0hHgJ/iqwqbT7E09rsK2XkpNRPC+eRMdWuo/Fk NI3furiYGju9oVomX8317C3fe6X/cwQ9c9wbBq8+nw8F//z2oZRZNZa4QokGFpITkz4G 2PapCcBXxMTgIoYy5whEU0rs7RrvEUolL1FQ5ovphdhhIpcdbLDx/LRtka5msJnEBMxA 7hSBD5SQG8LKCLXpk5hxeaTzAI0q7gElWui2/7cLkFCmh368yt9O6rKkZWcIgrFCRmHF wUy7CYAJFYPjXPxOvj+LkjMAS4QU3mTzJwUiyQb8vc0FVNLwfwnn7Q66Z7fJenTSrY+Q RkUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=U7cAtvh5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s1-v6si4167666pga.296.2018.06.21.07.59.21; Thu, 21 Jun 2018 07:59:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=U7cAtvh5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933266AbeFUO5V (ORCPT + 99 others); Thu, 21 Jun 2018 10:57:21 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:42947 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932963AbeFUO5S (ORCPT ); Thu, 21 Jun 2018 10:57:18 -0400 Received: by mail-lf0-f67.google.com with SMTP id z207-v6so4817630lff.9; Thu, 21 Jun 2018 07:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=JjJDpYrp1ZqrftXZ9az+npr+RsGHDvUIftSG0wiHdZU=; b=U7cAtvh5D1uxobXzDrfgEpE/+lIJV2vKPoc1kPPjBp1ytkY8mL3RJnDlUTHstK59nw XxQjiMqK9/BhG8Ct/vNBqXjAVKPaKTnIHky7gxBdD7MbpbR6xF9T0Pb+W3B0o7VOvvNR zSc8oFz/UyKKdzKNrMVDwrt7dC+Kh1yJ2EC+C8P8AyTlPUTuGY7RonPGu4azwSCP+IMl hF1oyKAig1D0nVXUcpO+87i/Bpq+Mz2LY5l0dOruldIK5KebjBPb+1EwHbEPqJ5iUX0G ArIwI/X/S0QiWqc1V1eCB81LTtOUnfnLTdN582jqz6F72BxjvKACep+FfWckks8Jq7E6 NbMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=JjJDpYrp1ZqrftXZ9az+npr+RsGHDvUIftSG0wiHdZU=; b=J74CYWfqGZrdZrQDC7tUfrzLU7iWwkE9DmJtwqYSvlO/HIK1qQrZn5Y71TC8ngEBWw /tVelFUoDKG2we0G77d7tzsEa/O8KQLyngtlCLVBixVDDBYr6IytW+V/uvy79kOKUYcE XeuZ4FlwTusj895ldiGhKYSPeFmzUeWaa91OyYdJg4TTbw1+HZlTYvK2xiBTDKghv7Ni 5oEjH0JG122QdrrO4YygclaORLXBaSMRJPO9iP0ohGGahNiTRr0wyn7bRDR7vgg4avyl Kyb7Jyi+gfnfF1BrJ189xG8nfq69kX2xrJ+itPJctjBQdkxQ7M/hKfatb6+poOo1QbhK tJlg== X-Gm-Message-State: APt69E2qgjd71lpbmvgl/OoFKTXB3OBvhitZnyq3VXLfnSbBxTviminH 6XOa/R7k1QrSfvILShSnR7zEK3mUzpwqBkdjTRw= X-Received: by 2002:a19:d5c7:: with SMTP id m190-v6mr6435699lfg.12.1529593036963; Thu, 21 Jun 2018 07:57:16 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:56c8:0:0:0:0:0 with HTTP; Thu, 21 Jun 2018 07:57:16 -0700 (PDT) In-Reply-To: References: <20180620155101.57685-1-arnd@arndb.de> <20180620155101.57685-4-arnd@arndb.de> From: Arnd Bergmann Date: Thu, 21 Jun 2018 16:57:16 +0200 X-Google-Sender-Auth: ks_wwwxcYO7y8GxgRJW5Wo2dAA4 Message-ID: Subject: Re: [PATCH 4/5] ceph: use timespec64 for r_mtime To: "Yan, Zheng" Cc: Zheng Yan , Sage Weil , Ilya Dryomov , Alex Elder , y2038 Mailman List , ceph-devel , Jens Axboe , David Miller , "Martin K. Petersen" , Jason Dillaman , daniel.m.jordan@oracle.com, Jan Kara , linux-block , Linux Kernel Mailing List , Networking Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 21, 2018 at 2:41 PM, Yan, Zheng wrote: > On Wed, Jun 20, 2018 at 11:55 PM Arnd Bergmann wrote: >> @@ -1013,7 +1013,7 @@ ceph_direct_read_write(struct kiocb *iocb, struct iov_iter *iter, >> truncate_inode_pages_range(inode->i_mapping, pos, >> (pos+len) | (PAGE_SIZE - 1)); >> >> - req->r_mtime = mtime; >> + req->r_mtime = current_time(inode); > this change is not needed Good catch, no idea how those two changes ended up in here, I'll resend without them. Thanks, Arnd