Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 21 Jun 2018 17:07:37 +0100
From:   Stefan Hajnoczi <stefanha@redhat.com>
To:     Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>
Cc:     davem@davemloft.net, jhansen@vmware.com, cavery@redhat.com,
        borntraeger@de.ibm.com, fiuczy@linux.ibm.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v1 1/1] VSOCK: fix loopback on big-endian systems
Message-ID: <20180621160737.GB7460@stefanha-x1.localdomain>
References: <1529502711-8028-1-git-send-email-imbrenda@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="kORqDWCi7qDJ0mEj"
Content-Disposition: inline
In-Reply-To: <1529502711-8028-1-git-send-email-imbrenda@linux.vnet.ibm.com>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--kORqDWCi7qDJ0mEj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 20, 2018 at 03:51:51PM +0200, Claudio Imbrenda wrote:
> The dst_cid and src_cid are 64 bits, therefore 64 bit accessors should be
> used, and in fact in virtio_transport_common.c only 64 bit accessors are
> used. Using 32 bit accessors for 64 bit values breaks big endian systems.
>=20
> This patch fixes a wrong use of le32_to_cpu in virtio_transport_send_pkt.
>=20
> Fixes: b9116823189e85ccf384 ("VSOCK: add loopback to virtio_transport")
>=20
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>
> ---
>  net/vmw_vsock/virtio_transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--kORqDWCi7qDJ0mEj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJbK81JAAoJEJykq7OBq3PI0jIIAJy5eUCfQZQyGX30y2ZNcF30
RrAhXeCm5sQ72UVotBgIeloRPNtzpN0tbXPQIBl+YNDDY1l+ZXACQ395DMHhLsGs
kgJJLcIDJVsojBlblxo1ZdVO4ZfvpSlN3gaM4HOqrYsb+Hwl+qJPP0fyB+duesRA
rctwL6BjMF/VG+32yt418kwf1sf2jD0wDfrPRIUYah00JIjvV2SXCeJBQTsDZNyz
poAuTEM2m5Pt6iNDC4+mcmJsMdwqNSIUs1xO29MGHNNEJyHi1zj5+KbKxBOPDlVS
sosICssaxkVPZU5Z9Ymw+GTBUo0PD8n1VgHSbYAX3P4X3xlKDJ+QuFTIPLBUdKE=
=/OTE
-----END PGP SIGNATURE-----

--kORqDWCi7qDJ0mEj--