Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 21 Jun 2018 21:45:46 +0200
Message-ID: <s5ha7rnditx.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Robert Jarzmik" <robert.jarzmik@free.fr>
Cc:     "Mark Rutland" <mark.rutland@arm.com>,
        "Liam Girdwood" <lgirdwood@gmail.com>,
        "Mark Brown" <broonie@kernel.org>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding
In-Reply-To: <20180621154356.5438-2-robert.jarzmik@free.fr>
References: <20180621154356.5438-1-robert.jarzmik@free.fr>
        <20180621154356.5438-2-robert.jarzmik@free.fr>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 21 Jun 2018 17:43:56 +0200,
Robert Jarzmik wrote:
> 
> Add a devicetree binding for codecs. This is especially useful if the
> AC97 bitclk clock is provided by the codec, as it has to be described in
> the devicetree description for the ac97 bus code to aquire it.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> Special review query: review the "return of_node_get(node)", which
> assumes that upon device removal, of_put_node(dev.of_node) will be
> called...

Is it really done automagically?  I couldn't spot it.


thanks,

Takashi