Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp24603imm; Thu, 21 Jun 2018 13:13:19 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKig/TVvY/ayc9A++6zX8b3dfbbQTv8TClqhow+9LCwiudKyxETABhI8SIv9VhKl8nsZ6My X-Received: by 2002:a17:902:8607:: with SMTP id f7-v6mr1064959plo.138.1529611999337; Thu, 21 Jun 2018 13:13:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529611999; cv=none; d=google.com; s=arc-20160816; b=IM3IVzWtTZAMQybt0zSmOwWcyLNq3eZb1YHHVwiXBmTXSludk0W1F6h9+KXrODN0yp OYgPeVNVo2Vuv7nU+aVNPyaKW2yUv+2gNqat3lOmSUOi+9uGco7d10u6ACTQB/wPxQv0 dfQAsHsLmd3Yz6MV/bsIQknYElDh32Rqlbvr+ttkks6ylfvxl6qreTEj1QuqJ9AdELx+ 7u3irEK5kWxGn36vK9szay58ZOYGEeduTNfxwUBsFGP+CY4XFX9wF4BDVEMG+HRlGx2F YWoaw//YZofjqB/LObWqRqUAdPh4cgz+91y1U3SE76lEq/GEa4Ta8BP7t3JwyIvGGfJJ LAFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=8EmkKY6gm6q1VIT2y7saUAFdNgQDP/z/9R86qcYMw9M=; b=FU9KWh26vNM7hdoDVePjCKlUrUl7Vwh+7dZ3PC4osfUwiZ5m8xArym+5WEKhZqcO6S +9PIQKUs0Kc30gHGLI3o0uGPLUUE3sfw0V3WfZbVreZpKeCcbYN/ELhbutFEvViTj2Ax dXPIeqdnd1VjBjzIeB+XvV6Lgae4un0XZWaaeUbLL4nhb/D4Q5POs5t8UB3sW94z0Q0P aJ0w14LdaWDWP5n0j0CLkB7njHBPEhmRh9lwamFobZL32pLTGCXA1rH4scSfzKF95fLh vkJuWsHBqr0DHcVPeYJFcgCwLJRlAIw3FzoSmbo4MMgJPLd4DoeUdsQpvjbhB02MvlY7 lJIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CeZoQPzo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n88-v6si5720134pfj.251.2018.06.21.13.13.04; Thu, 21 Jun 2018 13:13:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CeZoQPzo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933119AbeFUUMZ (ORCPT + 99 others); Thu, 21 Jun 2018 16:12:25 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:38179 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932621AbeFUUMX (ORCPT ); Thu, 21 Jun 2018 16:12:23 -0400 Received: by mail-pg0-f67.google.com with SMTP id c9-v6so1905366pgf.5 for ; Thu, 21 Jun 2018 13:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=8EmkKY6gm6q1VIT2y7saUAFdNgQDP/z/9R86qcYMw9M=; b=CeZoQPzomfPXZvADOjs59HirFJ/xFRv/YdOST3GinLoIBiMzx3FBT/Xl/lJsjGWCId zaF2JAmMd/iZxZ42Lr70g97LlNhg6Swz6Um4rOSlTIZEWJnumXpP7SVsO1lsnKu/lVhF ptWcrDkb157W+wD9A3ezAj4YJpXP5pi13IKWM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8EmkKY6gm6q1VIT2y7saUAFdNgQDP/z/9R86qcYMw9M=; b=N47zWPU10u0ZLoiIqvi6m/BZyEGTKRiBJwXzGWH7YwD/oizQ5jz0PDEe+AjA0wH0Jh XhwJst6cLJGIgJpprx/wbXSEgDulJ2bp71MfIbCIKmsbi02tQMvvpQ/o9RiIUIStHSPf w8utXybGzUMbyyhmrLuuW00R7e/ozwHcxRpGYXX+svpAHSFAu5R3Ndvn4vrGlcvDHBdm BJVTukL39hQtaMsSLMsugr4P3kyvODOxhari7z70QkNtxaHGskpaQibdglxYxGxK5yH3 0wxLLntocc7FFDqVmQJpF+CO8XxnquL1CTFH5T8pR6oVSD7kTzOBioBPY3aPEsW9M347 iJ/g== X-Gm-Message-State: APt69E1yYl1RQyU6kFeplo2fS5Ja0LHC+ghVd+xuV/74tMtH5ZDwDgUy 28aUf0GuzU4d1bGL6M5mXWnTmw== X-Received: by 2002:a65:46cb:: with SMTP id n11-v6mr23253195pgr.193.1529611943512; Thu, 21 Jun 2018 13:12:23 -0700 (PDT) Received: from delco2.sfo.corp.google.com ([2620:0:1002:19:b211:91ff:fab4:4e8]) by smtp.gmail.com with ESMTPSA id j13-v6sm6938338pgq.73.2018.06.21.13.12.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jun 2018 13:12:23 -0700 (PDT) From: Matt Delco To: AceLan Kao Cc: Darren Hart , Andy Shevchenko , platform-driver-x86@vger.kernel.or, linux-kernel@vger.kernel.org, Dmitry Torokhov , Matt Delco Subject: [PATCH] platform/x86: intel-vbtn: Ignore extraneous events from tablet mode Date: Thu, 21 Jun 2018 13:12:07 -0700 Message-Id: <20180621201207.178426-1-delco@chromium.org> X-Mailer: git-send-email 2.18.0.rc2.346.g013aa6912e-goog Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Dell laptop I have has an ACPI that sends 0xCB and 0xCC on entering tablet mode. On exiting tablet mode it sends 0xCA and 0xCD. This change has the driver ignore 0xCA and 0xCB. Signed-off-by: Matt Delco --- drivers/platform/x86/intel-vbtn.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c index c13780b8dabb..4c6f2bb1d1ac 100644 --- a/drivers/platform/x86/intel-vbtn.c +++ b/drivers/platform/x86/intel-vbtn.c @@ -38,8 +38,10 @@ static const struct key_entry intel_vbtn_keymap[] = { { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */ { KE_KEY, 0xC8, { KEY_ROTATE_LOCK_TOGGLE } }, /* rotate-lock key press */ { KE_KEY, 0xC9, { KEY_ROTATE_LOCK_TOGGLE } }, /* rotate-lock key release */ - { KE_SW, 0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tablet */ - { KE_SW, 0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Laptop */ + { KE_IGNORE, 0xCA, { KEY_UNKNOWN } }, /* Laptop key press */ + { KE_IGNORE, 0xCB, { KEY_UNKNOWN } }, /* Tablet key press */ + { KE_SW, 0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tablet key release */ + { KE_SW, 0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Laptop key release */ { KE_END }, }; -- 2.18.0.rc2.346.g013aa6912e-goog