Message-ID: <3F5E364E.2040409@terra.com.br>
Date: Tue, 09 Sep 2003 17:21:34 -0300
From: Felipe W Damasio <felipewd@terra.com.br>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021226 Debian/1.2.1-9
MIME-Version: 1.0
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Missing memory barrier on net/core/dev.c
References: <3F5E14D7.9030809@terra.com.br> <20030909124635.3c0d522b.davem@redhat.com>
In-Reply-To: <20030909124635.3c0d522b.davem@redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 795
Lines: 28

	Hi,

David S. Miller wrote:
> On Tue, 09 Sep 2003 14:58:47 -0300
> Felipe W Damasio <felipewd@terra.com.br> wrote:
> 
> 
>>	I *think* net/core/dev.c is missing a mb() before calling 
>>schedule_timoeut.
> 
> I have another patch in my queue from Andrew Morton that
> removes the TASK_RUNNING setting altogether, schedule_timeout()
> always returns with the task in that state.

	Ok, although that was not the main point of the patch :)

	What about the "set_current_state" before calling schedule_timeout. 
Isn't that mb() needed?

	Cheers,

Felipe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/