Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp97189imm; Thu, 21 Jun 2018 14:38:06 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJnmJPVI6TihesFiDpgNUv59XGkCXjG5MekV5Dg779Ls5RvzvA2RwP1+KvbjEx+m7mymf6r X-Received: by 2002:a63:9a52:: with SMTP id e18-v6mr23852069pgo.188.1529617086492; Thu, 21 Jun 2018 14:38:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529617086; cv=none; d=google.com; s=arc-20160816; b=eRV+3momDe2NkKq/Zvlv51Hr9DZcXcsamGE8HQ/1K7tmk8LNcLS/6EnfJh469Idf9/ mb65E+vT/8uSN3z9xYQ6etpBYQ47cVoDiq0mSe9dKsV5VZD8V7UEuVSen15ZJ9RJWwqa EHzJ9CQ0UIG9ywRPBHNw3E44r518gDf5yG1BFlcn6P76sSoRXJYjj10nB7FymFxCQSD7 bFhZa/2NYne+gOYevDDstuH1F9m4tlsPCK0UWJkCBqxXiAwKBCkjXoXOgteZwK1xnexv wrFi0STAcerY8AaZph6hsvVZ0SYkquTOHUHhEdOt42eDV833Xjd1y5Qz1XIieOFQA1xT 2T3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=xcV8He5co0DRYp3Csgj6T5Kq5Qgf1NYvM1EAEYgffy8=; b=Nh0igblxjIGQpDurqoMpJIWRkqtUGasYespXJd+Mw2qVuM2LrUFZ9ZmfU1jT9+z2QA nfJiODLUf/19XZjzvk0fIwOpDveVYqi6NDdjqzobmdpGCH5sSQ8GumNdkP5WEZFsOApS vD1VrQDD5VRFVFPEZz6zU14kZ4faY75XNC+lbIjGokwvrXtIffjDH279JDyfmdZvXR1v mT9pVIWUquFvbdl+RUvUp7eUsLqIu/b/Pxa/9s94e/ct7yUZwkfTqF178XXoL/o/JY7o Hl4Oht0P9BH3NCEfFMfkj7SeQ++BCGRfZt5XKEytcCAgzhzlaOQht0ZLKV1Oz9X+gajS tXVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v8-v6si5644731plo.322.2018.06.21.14.37.50; Thu, 21 Jun 2018 14:38:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934065AbeFUVgZ (ORCPT + 99 others); Thu, 21 Jun 2018 17:36:25 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:57759 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933731AbeFUV27 (ORCPT ); Thu, 21 Jun 2018 17:28:59 -0400 Received: from linux-r8p5.suse.cz (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Thu, 21 Jun 2018 15:28:48 -0600 From: Davidlohr Bueso To: akpm@linux-foundation.org, torvalds@linux-foundation.org Cc: tgraf@suug.ch, herbert@gondor.apana.org.au, manfred@colorfullife.com, mhocko@kernel.org, guillaume.knispel@supersonicimagine.com, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, dave@stgolabs.net Subject: [PATCH -next v3 0/4] rhashtable: guarantee initial allocation Date: Thu, 21 Jun 2018 14:28:21 -0700 Message-Id: <20180621212825.3059-1-dave@stgolabs.net> X-Mailer: git-send-email 2.16.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changes from v2: lkml.kernel.org/r/20180601160125.30031-1-dave@stgolabs.net - Dropped original patch 1 (which removed the EINVAL returns for WARN_ON) as well as patch 5. - Added a new patch 1, which simplifies the alloc after mhocko's changes (originally suggested by Linus). - Use max_t instead of min_t for the resize. Changes from v1 lkml.kernel.org/r/20180524211135.27760-1-dave@stgolabs.net - patch 2 is reworked a bit based on the commments from Herbert Xu. o upon failure, retry immediately with GFP_NOFAIL (simpler) o the caller now passes the needed semantics, not bucket_table_alloc(). o we consider min_size when resizing, not just HASH_MIN_SIZE. - removed patch 3; not need after Michal's patch. Hi, This series is the result of the discussion with Linus around ipc subsystem initialization and how it behaves with error return when calling rhashtable_init()[1]. Instead of caring about the error or calling the infamous BUG_ON, Linus suggested we guarantee the rhashtable allocation. First two patches deal with the rhashtable_init() changes, while the patches 3+4 remove some ipc hacks we no longer need. Please consider for v4.19. [0] https://lkml.org/lkml/2018/5/23/758 Thanks! Davidlohr Bueso (4): lib/rhashtable: simplify bucket_table_alloc() lib/rhashtable: guarantee initial hashtable allocation ipc: get rid of ids->tables_initialized hack ipc: simplify ipc initialization include/linux/ipc_namespace.h | 1 - ipc/msg.c | 9 ++++----- ipc/namespace.c | 20 ++++---------------- ipc/sem.c | 10 ++++------ ipc/shm.c | 9 ++++----- ipc/util.c | 41 +++++++++++++---------------------------- ipc/util.h | 18 +++++++++--------- lib/rhashtable.c | 19 ++++++++++++------- 8 files changed, 50 insertions(+), 77 deletions(-) -- 2.16.4