Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp244214imm; Thu, 21 Jun 2018 17:36:42 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLyIWhNMv/zXPyNj1f/B3jxn+mVl5Pxs1mQPsJ6e03020l4fWrV+kPLfuMWxL0vj1bVte1q X-Received: by 2002:a17:902:9f84:: with SMTP id g4-v6mr30975226plq.339.1529627802592; Thu, 21 Jun 2018 17:36:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529627802; cv=none; d=google.com; s=arc-20160816; b=iqABrqPbuyp4FvwSae7fqsKBtdVKfY0KzTzYM2E9gAYZL5fH2AoKA75yOewVDDs1nA DuuhMeBAZcIrKXHPPyk/bmBOr84Xy6gNh5Fs3JANiIwGrz0ZNZuEidiMEyTL7CaNBDNV 5sKevdNS1Uln0Bd7S9nbibyTYQw7UZ+WwCc/j2s1778SNW+K+gPmWXurbfMTpUEKauFI 5cmJoU7P/NuHCGefE94mQKpkiezpBTdarCL9BiMPXXMABgqTW8jV8h63vp4mTHoMT00L 10wAcN5Nzid7ul7G2frj3d5Ys96Mw0Rhvv+YNHxOTlGZm3yz/EJAuOyoeCVwpKJoeucq aU8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=NfVQkKuv4+h9gsTT5T/7RutIwOr00R2WSl8wyvA7EAU=; b=DIHqtotDT3KziF3LAf5LPfpJQ+bg1rvZ456H8vfBFbxksMEx1vJNwdx5z3E2qapqdj M/xMmBd2GxE1rZpOYxN31C/sO5b/l2B+Sx0D7H5x8eYeXjza4Gz2FmbMbiATkU8kfg3J Gsn8Ww/nNS8pXJjmMfx11+y4pW7h0vg9V+xEOY46QRIPtQcBTZ/zkdY9rqm0Gk/X+BL8 bgEyVKtRS9jgEIZztJfNzCjOv6AeqB8W/fsVryMDMiRBaz3n2JJoXg1YGCBMWs+4DtJe WDKAHUkhm8zIns9yZ4l//5Vvgk3Kl0HjSBNNIh8Kiyqgca7b/M0Jgp7LSy2NHOL+2G6i kSrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j9-v6si6125909pll.64.2018.06.21.17.36.28; Thu, 21 Jun 2018 17:36:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934012AbeFVAet (ORCPT + 99 others); Thu, 21 Jun 2018 20:34:49 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40488 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933379AbeFVAes (ORCPT ); Thu, 21 Jun 2018 20:34:48 -0400 Received: from localhost (unknown [119.205.93.152]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1BDFC12128E18; Thu, 21 Jun 2018 17:34:45 -0700 (PDT) Date: Fri, 22 Jun 2018 09:34:44 +0900 (KST) Message-Id: <20180622.093444.2175011617959103492.davem@davemloft.net> To: imbrenda@linux.vnet.ibm.com Cc: stefanha@redhat.com, jhansen@vmware.com, cavery@redhat.com, borntraeger@de.ibm.com, fiuczy@linux.ibm.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v1 1/1] VSOCK: fix loopback on big-endian systems From: David Miller In-Reply-To: <1529502711-8028-1-git-send-email-imbrenda@linux.vnet.ibm.com> References: <1529502711-8028-1-git-send-email-imbrenda@linux.vnet.ibm.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Jun 2018 17:34:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Claudio Imbrenda Date: Wed, 20 Jun 2018 15:51:51 +0200 > The dst_cid and src_cid are 64 bits, therefore 64 bit accessors should be > used, and in fact in virtio_transport_common.c only 64 bit accessors are > used. Using 32 bit accessors for 64 bit values breaks big endian systems. > > This patch fixes a wrong use of le32_to_cpu in virtio_transport_send_pkt. > > Fixes: b9116823189e85ccf384 ("VSOCK: add loopback to virtio_transport") > > Signed-off-by: Claudio Imbrenda Applied and queued up for -stable, thank you.