Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180322202007.23088-3-malat@debian.org> <20180328193028.823-1-malat@debian.org>
 <20180329180922.Horde.Mtq3N9paq5gkMn9QcIUlGQ1@messagerie.si.c-s.fr>
In-Reply-To: <20180329180922.Horde.Mtq3N9paq5gkMn9QcIUlGQ1@messagerie.si.c-s.fr>
From:   Mathieu Malaterre <malat@debian.org>
Date:   Fri, 22 Jun 2018 11:46:06 +0200
Message-ID: <CA+7wUsyGxY-bJbUyggpuHe9UBy+6yDiTiOM-qM0hz33TpqL6DQ@mail.gmail.com>
Subject: Re: [PATCH v2 02/19] powerpc/powermac: Mark variable x as unused
To:     Michael Ellerman <mpe@ellerman.id.au>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Christophe LEROY <christophe.leroy@c-s.fr>,
        linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
        Paul Mackerras <paulus@samba.org>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 29, 2018 at 6:09 PM LEROY Christophe
<christophe.leroy@c-s.fr> wrote:
>
> Mathieu Malaterre <malat@debian.org> a écrit :
>
> > Since the value of x is never intended to be read, remove it. Fix warning
> > treated as error with W=1:
> >
> >   arch/powerpc/platforms/powermac/udbg_scc.c:76:9: error: variable
> > ‘x’ set but not used [-Werror=unused-but-set-variable]
> >
> > Suggested-by: Christophe Leroy <christophe.leroy@c-s.fr>
> > Signed-off-by: Mathieu Malaterre <malat@debian.org>
>
> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>

Michael, can you take this one ?

> > ---
> > v2: remove x completely
> >
> >  arch/powerpc/platforms/powermac/udbg_scc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/powerpc/platforms/powermac/udbg_scc.c
> > b/arch/powerpc/platforms/powermac/udbg_scc.c
> > index d83135a9830e..8901973ed683 100644
> > --- a/arch/powerpc/platforms/powermac/udbg_scc.c
> > +++ b/arch/powerpc/platforms/powermac/udbg_scc.c
> > @@ -73,7 +73,7 @@ void udbg_scc_init(int force_scc)
> >       struct device_node *stdout = NULL, *escc = NULL, *macio = NULL;
> >       struct device_node *ch, *ch_def = NULL, *ch_a = NULL;
> >       const char *path;
> > -     int i, x;
> > +     int i;
> >
> >       escc = of_find_node_by_name(NULL, "escc");
> >       if (escc == NULL)
> > @@ -120,7 +120,7 @@ void udbg_scc_init(int force_scc)
> >       mb();
> >
> >       for (i = 20000; i != 0; --i)
> > -             x = in_8(sccc);
> > +             in_8(sccc);
> >       out_8(sccc, 0x09);              /* reset A or B side */
> >       out_8(sccc, 0xc0);
> >
> > --
> > 2.11.0
>
>