Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp649748imm; Fri, 22 Jun 2018 02:59:09 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLZRPCNpnFNWZ6kYxygxza03kR2lau32kBL8LObjvCXnCmsVxCZgJVMTLneSce8ulvwWz8v X-Received: by 2002:a17:902:5602:: with SMTP id h2-v6mr976771pli.314.1529661549506; Fri, 22 Jun 2018 02:59:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529661549; cv=none; d=google.com; s=arc-20160816; b=jAvZOnv3g6Nv2Bj77ikdG8YEMAXfshtpq3gmT/IxdLMu2X0WT+c5yZ4v9filtPeeVB HITrsGQ5LmMREIMb1EQYEFFScCzO3mnlxueTj393Wfb7XAlyfF+Mm5hnL1dEb6uKPGPo d713r4tLqvi/WQO/Gi5aRLKy3jDNHCTsJutwm7w3SIKaL5vpagNyJIok61MzHeGndGPr 7oW3PBPixS/76hSMvXvcs+B2g77pWnLQXx5rTjHvBw+Va7a5bf5Yq7mQqiZQadEEDNob bpQWaOroSx2VjIW0bdQaAVMt4hXpkRBt290rXFxIsBF5G9OTsv5G4JJtWLlJtm5Am9w0 QK1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=pLfh5Al0xMorvbxfo/eGPzjRL/1TfcEk8oP4Ffb+rj4=; b=CqAY3d1GAkfoQexeopN/sQkkwvlD45m6LXmoTNSnHmruZkeWSVxGAv1g55fnY71TmL BDAEUJNYPcYkCDP7u4Rk/xHkfBabtEqAlfwQKTpPGmNSE9ejq2GI5zKeeVGGQhWcXnKY plx4ZvrNuFJ0jlaHQYqIgEN97qa8pBc3umR4+6l4PWX3UlIxVp6hioZMBxKAHn4vXcfi R6idc8p4Qx0sfXqNLkpSdoE6nEYUbXGEjgkg36TM+ivp11qbUkVkmG9hmhD+2UcaksqC VZ1qPeNNp3BcBLfO9eSs7AECgdxvclKIT2gEhMTNO/qPGF+qt4Y8Fe7DzXlRPACtzCrS Dh3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z23-v6si6748237pfe.296.2018.06.22.02.58.55; Fri, 22 Jun 2018 02:59:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754252AbeFVJ6X (ORCPT + 99 others); Fri, 22 Jun 2018 05:58:23 -0400 Received: from wolverine01.qualcomm.com ([199.106.114.254]:37788 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338AbeFVJ6U (ORCPT ); Fri, 22 Jun 2018 05:58:20 -0400 X-IronPort-AV: E=Sophos;i="5.51,256,1526367600"; d="scan'208";a="346278387" Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by wolverine01.qualcomm.com with ESMTP; 22 Jun 2018 02:58:19 -0700 X-IronPort-AV: E=McAfee;i="5900,7806,8931"; a="186149719" Received: from westreach.qualcomm.com ([10.228.196.125]) by ironmsg03-sd.qualcomm.com with ESMTP; 22 Jun 2018 02:58:18 -0700 Received: by westreach.qualcomm.com (Postfix, from userid 467151) id 3FE391F32; Fri, 22 Jun 2018 05:58:18 -0400 (EDT) From: Oza Pawandeep To: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi Cc: Oza Pawandeep Subject: [PATCH v2 3/6] PCI/ERR: Cleanup ERR_FATAL of error broadcast Date: Fri, 22 Jun 2018 05:58:11 -0400 Message-Id: <1529661494-20936-4-git-send-email-poza@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1529661494-20936-1-git-send-email-poza@codeaurora.org> References: <1529661494-20936-1-git-send-email-poza@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ERR_FATAL is handled by resetting the Link in software, skipping the driver pci_error_handlers callbacks, removing the devices from the PCI subsystem, and re-enumerating, so now no more ERR_FATAL handling is required inside pci_broadcast_error_message() Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c index 00d2875..404bb69 100644 --- a/drivers/pci/pcie/err.c +++ b/drivers/pci/pcie/err.c @@ -259,15 +259,10 @@ static pci_ers_result_t broadcast_error_message(struct pci_dev *dev, /* * If the error is reported by an end point, we think this * error is related to the upstream link of the end point. + * the error is non fatal so the bus is ok, just invoke + * the callback for the function that logged the error. */ - if (state == pci_channel_io_normal) - /* - * the error is non fatal so the bus is ok, just invoke - * the callback for the function that logged the error. - */ - cb(dev, &result_data); - else - pci_walk_bus(dev->bus, cb, &result_data); + cb(dev, &result_data); } return result_data.result; -- 2.7.4