Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 2/2] arm64: dts: exynos: add OF graph between USB-PHY
 and MUIC
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     "open list:DESIGNWARE USB3 DRD IP DRIVER" <linux-usb@vger.kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Inki Dae <inki.dae@samsung.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
From:   Andrzej Hajda <a.hajda@samsung.com>
Date:   Fri, 22 Jun 2018 12:39:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
        Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180620182844.5nmlj5djbjgwy3wn@kozik-lap>
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Message-Id: <20180622103910eucas1p239a4f8545b3ef340fe5d0a8b954c48ac~6dUIg5f5F1882718827eucas1p2e@eucas1p2.samsung.com>
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20180515121239.18192-1-a.hajda@samsung.com>
        <CGME20180515121251eucas1p160dd3dcff49f0dad845ed6be98f33bbe@eucas1p1.samsung.com>
        <20180515121239.18192-3-a.hajda@samsung.com>
        <20180620182844.5nmlj5djbjgwy3wn@kozik-lap>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 20.06.2018 20:28, Krzysztof Kozlowski wrote:
> On Tue, May 15, 2018 at 02:12:39PM +0200, Andrzej Hajda wrote:
>> OF graph describes USB data lanes between USB-PHY and respective MUIC.
>> Since graph is present and DWC driver can use it to get extcon, obsolete
>> extcon property can be removed.
>>
>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>> ---
>>  .../dts/exynos/exynos5433-tm2-common.dtsi     | 19 ++++++++++++++++++-
>>  1 file changed, 18 insertions(+), 1 deletion(-)
> dtc W=1 now complains with:
> ===
> Warning (graph_child_address):
> /soc/hsi2c@14d90000/max77843@66/max77843-muic/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> ===
>
> Do you plan to add more ports soon?

There could be a link between UART and MUIC, it could be beneficial for
the platform - there is no point to feed UART with data when UART output
is muxed-out by MUIC.
So I plan to investigate it but this is not on my short list :)
Alternatively one can create graphs without using it atm.

Regards
Andrzej

>
> Best regards,
> Krzysztof
>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
>> index 03453b822093..042e5894a138 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
>> @@ -868,6 +868,18 @@
>>  					};
>>  				};
>>  			};
>> +
>> +			ports {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +
>> +				port@0 {
>> +					reg = <0>;
>> +					muic_to_usb: endpoint {
>> +						remote-endpoint = <&usb_to_muic>;
>> +					};
>> +				};
>> +			};
>>  		};
>>  
>>  		regulators {
>> @@ -1287,12 +1299,17 @@
>>  
>>  &usbdrd_dwc3 {
>>  	dr_mode = "otg";
>> -	extcon = <&muic>;
>>  };
>>  
>>  &usbdrd30_phy {
>>  	vbus-supply = <&safeout1_reg>;
>>  	status = "okay";
>> +
>> +	port {
>> +		usb_to_muic: endpoint {
>> +			remote-endpoint = <&muic_to_usb>;
>> +		};
>> +	};
>>  };
>>  
>>  &xxti {
>> -- 
>> 2.17.0
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
>