Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 22 Jun 2018 12:49:49 +0200
Message-ID: <s5h8t77hz8y.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Robert Jarzmik <robert.jarzmik@free.fr>
Cc:     "Mark Rutland" <mark.rutland@arm.com>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Liam Girdwood" <lgirdwood@gmail.com>,
        "Mark Brown" <broonie@kernel.org>,
        "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding
In-Reply-To: <874lhvnlx1.fsf@belgarion.home>
References: <20180621154356.5438-1-robert.jarzmik@free.fr>
        <20180621154356.5438-2-robert.jarzmik@free.fr>
        <s5ha7rnditx.wl-tiwai@suse.de>
        <874lhvnlx1.fsf@belgarion.home>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 22 Jun 2018 12:41:14 +0200,
Robert Jarzmik wrote:
> 
> Takashi Iwai <tiwai@suse.de> writes:
> 
> >> Special review query: review the "return of_node_get(node)", which
> >> assumes that upon device removal, of_put_node(dev.of_node) will be
> >> called...
> >
> > Is it really done automagically?  I couldn't spot it.
> Neither could I ...
> 
> I based this on device_set_of_node_from_dev(), and the it "seemed" logical to me
> that a device probed from devicetree would take a refcnt on the devicetree node.
> 
> As the "logical" conflicted with my search for the automagical of_node_get(), I
> need the special review query.

Hm, some of these users (e.g. drivers/usb/core/*) do call
of_node_put() properly at releasing, but some look leaking to me.
I don't think we have the common code in the driver core to release
dev->of_node, at least.

If any, this should be done in ac97_codec_release(), I suppose.


Takashi