Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp934998imm; Fri, 22 Jun 2018 07:45:03 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKazOc9XJjPUYbFFjLC/a8j9sia+XhWBmh8l+iPDDrmNSJdEGihQrLf/W+P57fTjLbUbCpV X-Received: by 2002:a63:9b19:: with SMTP id r25-v6mr1640324pgd.197.1529678703659; Fri, 22 Jun 2018 07:45:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529678703; cv=none; d=google.com; s=arc-20160816; b=IadEYGTlrIMWNioM+JP89Tra93MkeeJ6eWGHuzPyF+ULQM0wDlS3sB5E9gthmvmXMr P6sIgUO7DDntUUrYATXLy9UiW9d06SwheRw5IAxpa4cKGzugSicwpmmgk08to2LuCkDB 6dtII4utL933VUs5t167apWq+mdoPIQr3XRmLiAJc/bWbA5e4pXwuTrs0QclO5y3uORp 46WAXRqZcI+hHqm6cSPbrdaSHKBXPeKwTTHTn7HccDrFcunzT4syP9lM00WVuSpfo208 ZlvSFpZSodKzfYmHaDmDHdh7xByzutE6Z0Qdam3V9tUDmM0Ni9g1ofVg6pUQr8yDehQH csGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=yVsXhlmaw5nNWNh/i8zsPZu5iSO7+FFoWqchtuq6SVM=; b=SKV4O39UF87lPbKOV8ECuIx+PVSCDLEGcDgDIoSsncqRHCIuC4KPdhBnE3ggb0pQS8 SQr3CdC3nqg/QvQU2YZhMggNPR78UEzIGKAgPA6cqr5qv1YWP2EbNj5eSBz3PJrwq8Xu 6KcBMdIl+FnjZM2hypa/Ha+RDAzmIjEVn9Kz0HuOsQe4l8qHp6+1rdcOIzMOv+6koOG1 /SCk7LFv4D8Gr25ksSfIQ71g1bWvJGWVI+vYvSOA3xm1pe4ruORoS733fqi7SjN7NWFs Z+mK/9FBDeUI3kbpVyqFm8uXzfc5aWrzfEl6baJc2pZRLTXg/WioDrD2Z3Yu47BF3f8x soow== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=HEmPvvNR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e90-v6si7383236pfb.185.2018.06.22.07.44.49; Fri, 22 Jun 2018 07:45:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=HEmPvvNR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933585AbeFVOnr (ORCPT + 99 others); Fri, 22 Jun 2018 10:43:47 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:49644 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932752AbeFVOnp (ORCPT ); Fri, 22 Jun 2018 10:43:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yVsXhlmaw5nNWNh/i8zsPZu5iSO7+FFoWqchtuq6SVM=; b=HEmPvvNRkTkwCZAnDHWM1lfh2 HpQB5jBkdIckhD0HnLhZTN8/6gwX4x52kuY0XqmQkz2Q4+QCQnT8fglqsrh5QBaBEtD5h0Lj+PI/P oNhagZrTCHb+33136kKXxJvGv294w7lpi13FGORQkHvPClAuY9l9rY6HLWlaupzsvlUIY=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fWNHm-0003u0-Kl; Fri, 22 Jun 2018 14:43:38 +0000 Received: from broonie by debutante with local (Exim 4.91) (envelope-from ) id 1fWNHl-0002FS-PA; Fri, 22 Jun 2018 15:43:37 +0100 Date: Fri, 22 Jun 2018 15:43:37 +0100 From: Mark Brown To: Takashi Iwai Cc: Robert Jarzmik , Mark Rutland , Rob Herring , Liam Girdwood , Jaroslav Kysela , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding Message-ID: <20180622144337.GB15386@sirena.org.uk> References: <20180621154356.5438-1-robert.jarzmik@free.fr> <20180621154356.5438-2-robert.jarzmik@free.fr> <874lhvnlx1.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="98e8jtXdkpgskNou" Content-Disposition: inline In-Reply-To: X-Cookie: Kiss your keyboard goodbye! User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --98e8jtXdkpgskNou Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 22, 2018 at 12:49:49PM +0200, Takashi Iwai wrote: > Hm, some of these users (e.g. drivers/usb/core/*) do call > of_node_put() properly at releasing, but some look leaking to me. > I don't think we have the common code in the driver core to release > dev->of_node, at least. > If any, this should be done in ac97_codec_release(), I suppose. Yeah, I'd expect this to be handled in each bus. --98e8jtXdkpgskNou Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlstCxkACgkQJNaLcl1U h9Bbdwf/TnACvLBod1Z4z6L39QVRhG7Gud/6osipDCfZHAgnSaNdm9uGXovl16FB LfjKnlRib6KOmA6yzImHzyZpFxYCbRYBWCxC7ZSDl7Pi60EZOuaxPflBF4h7Ywzs UQmbrnAl+ihLp+bLWy8k1frZ19z0e+J7UkZvNJrFf2FQP1c6dY+ugG4cGZvl95rj ezI+rUamPBjwvZ123qSqXsvdp2j8iHYcRYv32M0Jm5t5+jyrDR0lo4MXxPKj/lR4 mYLtL0tF9HdkgD3B+Xvg4aJ3716XY4TKnnj6XCyAyvCNwTNZMOXHZ6tMLLltdOrO lA1LJiSK/9/l9Jk0Day9uFNUPD2uCg== =x2fN -----END PGP SIGNATURE----- --98e8jtXdkpgskNou--