Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v4 7/7] x86/vdso: Move out the CPU number store
From:   Andy Lutomirski <luto@amacapital.net>
In-Reply-To: <alpine.DEB.2.21.1806221714260.2402@nanos.tec.linutronix.de>
Date:   Fri, 22 Jun 2018 09:11:42 -0700
Cc:     "Chang S. Bae" <chang.seok.bae@intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        "H . Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Markus T Metzger <markus.t.metzger@intel.com>,
        Ravi Shankar <ravi.v.shankar@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <80C1F514-1B4D-4CDC-BD46-6C3AA9601446@amacapital.net>
References: <1529536506-26237-1-git-send-email-chang.seok.bae@intel.com> <1529536506-26237-8-git-send-email-chang.seok.bae@intel.com> <alpine.DEB.2.21.1806221714260.2402@nanos.tec.linutronix.de>
To:     Thomas Gleixner <tglx@linutronix.de>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Jun 22, 2018, at 8:18 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
>=20
>> On Wed, 20 Jun 2018, Chang S. Bae wrote:
>>=20
>> +#ifdef CONFIG_X86_64
>> +static void setup_cpu_number(int cpu)
>=20
> This function name is really misleading. vdso_setup_cpu_and_node() or
> something like that clearly tells what this is about.
>=20

Ah. The big secret is that it=E2=80=99s not just vDSO, or at lease hpa wants=
 to start using it in the entry code.

> Thanks,
>=20
>    tglx