Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264286AbTIJBMR (ORCPT ); Tue, 9 Sep 2003 21:12:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264471AbTIJBMR (ORCPT ); Tue, 9 Sep 2003 21:12:17 -0400 Received: from mion.elka.pw.edu.pl ([194.29.160.35]:48577 "EHLO mion.elka.pw.edu.pl") by vger.kernel.org with ESMTP id S264286AbTIJBMQ (ORCPT ); Tue, 9 Sep 2003 21:12:16 -0400 From: Bartlomiej Zolnierkiewicz To: "Randy.Dunlap" Subject: Re: [PATCH] pdc4030: return needs value; function needs return; Date: Wed, 10 Sep 2003 03:14:26 +0200 User-Agent: KMail/1.5 Cc: akpm@osdl.org, lkml References: <20030909165414.2f0a5113.rddunlap@osdl.org> In-Reply-To: <20030909165414.2f0a5113.rddunlap@osdl.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200309100314.26305.bzolnier@elka.pw.edu.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 583 Lines: 24 Hi, On Wednesday 10 of September 2003 01:54, Randy.Dunlap wrote: > @@ -317,7 +317,7 @@ int __init ide_probe_for_pdc4030(void) > #endif > } > } > -#ifdef MODULE > +#ifndef MODULE > return 0; > #endif > } This is wrong, we will now get warning for module instead of built-in. Proper fix is to remove this #ifdef. --bartlomiej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/