Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1046083imm; Fri, 22 Jun 2018 09:24:51 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJL7BXyHlJUvsrpLONmSUFdEYXZ06t7EcLzZpQIJRfK6vgyDJiEUKLyX4m/mu6CCkRSjVRM X-Received: by 2002:a65:444f:: with SMTP id e15-v6mr389915pgq.348.1529684691405; Fri, 22 Jun 2018 09:24:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529684691; cv=none; d=google.com; s=arc-20160816; b=mezQRDKC67JTjdzFk/mq8Qumu6tIAkLqRZ+ruWpY3DsWLW5Cw2XLz3dyMPgWWxaSVF fio9grd8eoI6JZKd2LsbECgOpA+uBUzXZi9zpsiO++35uYnZWg0JlFgi0ADbdQwwWAEe 2GqfVu6JHgn0lnm2yOMfN3s6g7OMt8Cpul4uRbk9W0jlXO3uHf3BHHDgwgq1E5ovH9cM blrLt9iTTZ3mpTjyExwZf58soSIyhs7h4SEDDWLvRK3eo7SCuHKrZZqDSIM8nERRFGb3 5cfmvye26chqL7RCGtzNO4Dvn3G6SxBL5zCHgPaStJBxGLeFNA3LeUcike59sipMvqBd kxqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=q1fBPloor/QRv1fhtcYeOnvmTdomVFFI9gmtrcB21gA=; b=g3Uc1fxLHtLvv1sheainvXKhksbdQm/acG0i/HxljckMjbnZhOZCYFSmSxoDqfA1kd 788Ihgyy6zyiRexe2+UAqr/F2SGSKn+AOnWWi2CDHZZfCPY7TsWg5IyTvstRWVXohlFY ZP5ujMrAzH5yXFjI9XdSc7rqYeLRHQQQc1tRFGR2ICHZDDjGj+KD93/hkv9IAQ4aUHWl 0cn+KPtpj2gNCJRt3pmNxd9ZPAumP9VwwrjWBgLPORDBUe62qtVzdJR/DoNixxKbOS+t iRSkpgwNcjqQqOwb6/8bc+eyx53jsdpXE3lIqMtoqDo5tn++lgNT8U/60S2mcBXxRO+6 u61Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i2-v6si6635832pgo.289.2018.06.22.09.24.25; Fri, 22 Jun 2018 09:24:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934299AbeFVQXf (ORCPT + 99 others); Fri, 22 Jun 2018 12:23:35 -0400 Received: from www.llwyncelyn.cymru ([82.70.14.225]:60512 "EHLO fuzix.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934203AbeFVQXc (ORCPT ); Fri, 22 Jun 2018 12:23:32 -0400 Received: from alans-desktop (82-70-14-226.dsl.in-addr.zen.co.uk [82.70.14.226]) by fuzix.org (8.15.2/8.15.2) with ESMTP id w5MGL1nR001418; Fri, 22 Jun 2018 17:21:01 +0100 Date: Fri, 22 Jun 2018 17:21:00 +0100 From: Alan Cox To: Linus Torvalds Cc: Steven Rostedt , Petr Mladek , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Peter Zijlstra , Andrew Morton , Dmitry Vyukov , Linux Kernel Mailing List , linux-serial , SergeySenozhatsky Subject: Re: [RFC][PATCH 0/6] Use printk_safe context for TTY and UART port locks Message-ID: <20180622172100.2293b5e5@alans-desktop> In-Reply-To: References: <20180615093919.559-1-sergey.senozhatsky@gmail.com> <20180618143818.50b2f2f9@alans-desktop> <20180619005308.GA405@jagdpanzerIV> <20180619083021.4avsgvcqjrpkat6s@pathway.suse.cz> <20180619223447.4369748b@vmware.local.home> Organization: Intel Corporation X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Jun 2018 11:44:13 +0900 Linus Torvalds wrote: > On Wed, Jun 20, 2018 at 11:34 AM Steven Rostedt wrote: > > > > Perhaps we should do an audit of the console drivers and remove all > > printk, pr_* , WARN*, BUG* from them. > > Only the actual _printing_ parts. No because they are normally rather useful because that port isn't the console. If you trylock it as I suggested then at least you'd just drop the recursive cases and get messages otherwise. Really that's all that you need - log the message to whichever console targets you can currently safely do so. If it's none well there was always the proposed morse code keyboard light driver 8) Alan