Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 22 Jun 2018 18:54:16 +0100
Message-ID: <86k1qq7lmf.wl-marc.zyngier@arm.com>
From:   Marc Zyngier <marc.zyngier@arm.com>
To:     Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Shanker Donthineni <shankerd@codeaurora.org>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Lei Zhang <zhang.lei@jp.fujitsu.com>,
        Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH 6/7] irqchip/gic-v3-its: Honor hypervisor enforced LPI range
In-Reply-To: <5FC3163CFD30C246ABAA99954A238FA838706A1B@FRAEML521-MBX.china.huawei.com>
References: <20180620135234.32101-1-marc.zyngier@arm.com>
        <20180620135234.32101-7-marc.zyngier@arm.com>
        <5FC3163CFD30C246ABAA99954A238FA838706A1B@FRAEML521-MBX.china.huawei.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
Organization: ARM Ltd
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Shammer,

On Fri, 22 Jun 2018 17:31:40 +0100,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> wrote:
> 
> Hi Marc,
> 
> > -----Original Message-----
> > From: Marc Zyngier [mailto:marc.zyngier@arm.com]
> > Sent: 20 June 2018 14:53
> > To: linux-kernel@vger.kernel.org
> > Cc: Thomas Gleixner <tglx@linutronix.de>; Ard Biesheuvel
> > <ard.biesheuvel@linaro.org>; Shanker Donthineni
> > <shankerd@codeaurora.org>; Shameerali Kolothum Thodi
> > <shameerali.kolothum.thodi@huawei.com>; MaJun <majun258@huawei.com>;
> > Laurentiu Tudor <laurentiu.tudor@nxp.com>; Lei Zhang
> > <zhang.lei@jp.fujitsu.com>
> > Subject: [PATCH 6/7] irqchip/gic-v3-its: Honor hypervisor enforced LPI range
> > 
> > A recent extension to the GIC architecture allows a hypervisor to
> > arbitrarily reduce the number of LPIs available to a guest, no
> > matter what the GIC says about the valid range of IntIDs.
> > 
> > Let's factor in this information when computing the number of
> > available LPIs
> 
> On our D05 board, this limits the lpis to 2 and results in MSI irq
> alloc fails:
> 
> [    0.000000] ITS: Using hypervisor restricted LPI range [2]
> ....
> [   10.543889] ixgbe 000a:11:00.1: Failed to allocate MSI interrupt, falling back to legacy. Error: -12
>  
> > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> > ---
> >  drivers/irqchip/irq-gic-v3-its.c   | 9 +++++++++
> >  include/linux/irqchip/arm-gic-v3.h | 1 +
> >  2 files changed, 10 insertions(+)
> > 
> > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> > index 8c7e8c235faf..903ca1c19553 100644
> > --- a/drivers/irqchip/irq-gic-v3-its.c
> > +++ b/drivers/irqchip/irq-gic-v3-its.c
> > @@ -1525,8 +1525,17 @@ static int free_lpi_range(u32 base, u32 nr_lpis)
> >  static int __init its_lpi_init(u32 id_bits)
> >  {
> >  	u32 lpis = (1UL << id_bits) - 8192;
> > +	u32 numlpis;
> >  	int err;
> > 
> > +	numlpis = 1UL << GICD_TYPER_NUM_LPIS(gic_rdists->gicd_typer);
> > +
> > +	if (numlpis > 1 && !WARN_ON(numlpis > lpis)) {
> > +		lpis = numlpis;
> > +		pr_info("ITS: Using hypervisor restricted LPI range [%u]\n",
> > +			lpis);
> > +	}
> 
> I don't have the GICv3 extension doc, but did you intent to check for,
> 
>  if (numlpis > 2 && !WARN_ON(numlpis > lpis)) {
> 
> as it looks like D05 returns 0 for bits 11-15 and that makes numlpis=2.

Absolutely. This really is a silly bug, thanks for catching that one.
I've pushed out an update on my irq/lpi-allocator branch.

Thanks,

	M.

-- 
Jazz is not dead, it just smell funny.